Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/#22] 최근 길 안내 장소 API 구현 #23

Merged
merged 9 commits into from
Jan 17, 2025
Merged

[FEAT/#22] 최근 길 안내 장소 API 구현 #23

merged 9 commits into from
Jan 17, 2025

Conversation

gahyuun
Copy link
Collaborator

@gahyuun gahyuun commented Jan 16, 2025

💡 Issue

📸 Screenshot

image

📄 Description

  • spodId를 사용자가 전달하면 유효한 장소인지 확인 후 최근 길 안내 테이블에 저장하도록 구현하였습니다.
  • 저희 테이블명이 "최근 길 안내"이고 기획에서도 최근 길 안내한 몇 개의 장소만 필요하므로, 특정 시점마다 불필요한 안내 장소는 삭제하는 게 맞을까요 ?!

💬 To Reviewers

  • Spot Id를 담는 DTO가 필요해서 Spot 도메인에 Spot Request를 생성했는데, Member 도메인에서 Spot DTO를 사용하고 해당 API가 Spot, Member 중 하나의 도메인으로 결정될 수 있을까라는 의문이 다시 생겼어요 .. ! 이 부분에 대해서 다시 한 번 논의를 해도 좋을 것 같아요 🤗

@gahyuun gahyuun added ✨ FEAT 새로운 기능 추가 🦊 가현 labels Jan 16, 2025
@gahyuun gahyuun self-assigned this Jan 16, 2025
@gahyuun gahyuun requested a review from ckkim817 as a code owner January 16, 2025 13:52
@gahyuun gahyuun added the size/S label Jan 16, 2025
@gahyuun gahyuun added size/XXL and removed size/S labels Jan 17, 2025
Copy link
Member

@ckkim817 ckkim817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 어푸어푸 🌊

@gahyuun gahyuun merged commit 3b93136 into develop Jan 17, 2025
1 check passed
@gahyuun gahyuun deleted the feat/#22 branch January 17, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 최근 길 안내 저장 API 구현
2 participants