Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Mode should not hide items #121

Open
bibermann opened this issue Feb 27, 2023 · 1 comment
Open

Private Mode should not hide items #121

bibermann opened this issue Feb 27, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bibermann
Copy link

Problem description

I would like to have access to the clipboard history in both Private and Non-Private modes.

Potential solutions/workarounds

Suggested solution:

  • Either remove the feature of hiding the history, or,
  • if there is a use-case that I do not see, add an option to disable this behavior.

Workaround: Switch to Non-Private mode to get access to those items. But this increases the risk of forgetting to switch back to Private later.

Additional context

The docs say:

Use Private mode to temporarily stop processing copied items.

So in my understanding this solves the issue when I want to copy things like passwords but do not want that those are stored anywhere.

The question is, why are already added items hidden then? They are not private, otherwise, they would not have been added in the first place.

@bibermann bibermann added the enhancement New feature or request label Feb 27, 2023
@SUPERCILEX
Copy link
Owner

I was going to say there's probably a good reason but nope lol: Tudmotu/gnome-shell-extension-clipboard-indicator@51c687f#diff-19a9a3efb94bf1b84229bda71ab0ef5badcdbf34ba3a0c9e4152a82c569a21e6R330

I'd be happy to accept a PR for this. It'd mostly be deleting stuff and then moving the private check into the clipboard listener so that we know when to remove the little dot indicator.

@SUPERCILEX SUPERCILEX added the help wanted Extra attention is needed label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants