Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): fix bug in search bar on challenge search page #2687

Merged
merged 3 commits into from
May 17, 2024
Merged

fix(openchallenges): fix bug in search bar on challenge search page #2687

merged 3 commits into from
May 17, 2024

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented May 17, 2024 •
edited by tschaffter
Loading

Description

The same function is used for challenge search bar (searchType = "challenges") and dropdown filter search bars, but some variables used for dropdown filters is never defined for "challenges".

Changelog

  • moving those variables into the dropdown filter logics.

@rrchai rrchai self-assigned this May 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rrchai rrchai marked this pull request as ready for review May 17, 2024 19:23
@rrchai rrchai requested review from tschaffter and vpchung as code owners May 17, 2024 19:23
@rrchai rrchai changed the title fix(openchallenges): set default for the lazy loading variables on search page to avoid issue in SSR environment fix(openchallenges): set default values for the lazy loading variables on search page to avoid issue in SSR environment May 17, 2024
@rrchai rrchai changed the title fix(openchallenges): set default values for the lazy loading variables on search page to avoid issue in SSR environment fix(openchallenges): fix bug in search bar on challenge search page May 17, 2024
@tschaffter tschaffter merged commit b1f66e4 into Sage-Bionetworks:main May 17, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter Awaiting requested review from tschaffter tschaffter is a code owner

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@rrchai rrchai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The challenge search bar no longer works
2 participants
@rrchai @tschaffter