Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Contributors of the MIDI-B challenge are not visible #2703

Closed
3 tasks done
tschaffter opened this issue Jun 8, 2024 · 4 comments · Fixed by #2708
Closed
3 tasks done

[Bug] Contributors of the MIDI-B challenge are not visible #2703

tschaffter opened this issue Jun 8, 2024 · 4 comments · Fixed by #2708
Assignees
Labels
bug Something isn't working

Comments

@tschaffter
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What product(s) are you seeing the problem on?

OpenChallenges

Current behavior

The contributors of the MIDI-B challenge are not visible on main and in prod. Other challenges successfully show their contributors.

http://localhost:8000/challenge/517/midi-b?tab=contributors

The console shows that the page is trying to make the following request, which fails:

http://localhost:8082/api/v1/organizations/475

Http failure response for http://localhost:8082/api/v1/organizations/475: 404 Not Found

http://localhost:8000/api/v1/organizations/475

{
  "title": "Entity not found",
  "status": 404,
  "detail": "The organization with the ID or login 475 does not exist.",
  "type": "ORGANIZATION-SERVICE-1000"
}

Expected behavior

The contributors should be visible.

Anything else?

This challenge has multiple contributors, but none are displayed. Wondering whether one contributor breaking is preventing all the other contributors for this challenge to be displayed.

Commit ID

40bcf76

Are you developing inside the dev container?

  • I am using the dev container

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tschaffter tschaffter added the bug Something isn't working label Jun 8, 2024
@tschaffter tschaffter self-assigned this Jun 8, 2024
@tschaffter
Copy link
Member Author

tschaffter commented Jun 8, 2024

Contribution roles for this challenge (ID 517):

"1215","517","15","challenge_organizer"
"1216","517","171","challenge_organizer"
"1217","517","473","challenge_organizer"
"1218","517","474","challenge_organizer"
"1219","517","475","challenge_organizer"
"1220","517","476","challenge_organizer"
"1221","517","477","challenge_organizer"
"1222","517","131","challenge_organizer"
"1224","517","15","data_contributor"

The org 475 is the only one that is not found.

@tschaffter
Copy link
Member Author

@gaiaandreoletti @vpchung The data of the org with ID 475 is breaking the CSV file because of the comma in the name of the org.

"475","Ellumen, Inc.","ellumen,-inc","logo/ellumen.jpg",...

@vpchung
Copy link
Member

vpchung commented Jun 10, 2024

I don't think the problem is the comma in the name of the organization (since we have University of California, San Fransisco + others and those are rendering fine), but the slug is incorrect. Will fix the formatting rules and add a validation check to the data sheet.

EDIT: formatting rule has been updated + validation check has been added for organization.login. Fix should be deployed in the next DB PR update.

@tschaffter
Copy link
Member Author

I just triggered the GH workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants