Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sage-monorepo): fix VS Code config for formatting JSON and JSONC files #2787

Merged

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Aug 30, 2024

Fixes #2786

Description

The JSON formatter VS Code ships with was actually used to format files on save instead of Prettier. This formatting would have been different from the formatting created when formatting files as part of git hooks.

Changelog

  • Fix the VS Code settings for formatting JSON and JSONC files (see original issue for more info)

Notes

If you see the following warning when clicking on the button in VS Code footer, make sure that the VS Code extension Prettier - Code formatter is installed inside the dev container:

image

@tschaffter tschaffter marked this pull request as ready for review August 30, 2024 23:50
@tschaffter tschaffter requested a review from sagely1 August 30, 2024 23:52
Copy link
Contributor

@sagely1 sagely1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tschaffter tschaffter merged commit 95f6051 into Sage-Bionetworks:main Aug 31, 2024
8 of 9 checks passed
@tschaffter tschaffter deleted the sage-monorepo/fix-json-formatting branch August 31, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Identify and apply a single JSON formatting
2 participants