Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorblind-friendly color schemes #31

Open
nateberkopec opened this issue Jun 27, 2019 · 3 comments
Open

Colorblind-friendly color schemes #31

nateberkopec opened this issue Jun 27, 2019 · 3 comments

Comments

@nateberkopec
Copy link

nateberkopec commented Jun 27, 2019

https://github.com/SamSaffron/flamegraph/blob/master/lib/flamegraph/flamegraph.html#L367

I would need to do more research but I imagine a) avoiding certain combinations of red/green, etc and b) adding some brightness variations, texture variations could help.

Ideally I think you would use this in RMP like http://localhost:3000/?pp=flamegraph&colorblind=deut or &colorblind=prot, etc

from Justin Weiss: https://t.co/ac6mty2Nxz

@SamSaffron
Copy link
Owner

Sure ... I support this change! By default we should have a color blind friendly theme imo.

@nateberkopec
Copy link
Author

Google claims their new color scheme is usable by 99.997% of the population: https://ai.googleblog.com/2019/08/turbo-improved-rainbow-colormap-for.html

Example implementations included.

@nateberkopec
Copy link
Author

and here's a JS implementation by Mike Bostock of D3 fame: https://observablehq.com/@mbostock/turbo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants