Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to change the mesh scalar before a clip is loaded #10

Open
tim-depthkit opened this issue Apr 29, 2020 · 0 comments
Open

Add a way to change the mesh scalar before a clip is loaded #10

tim-depthkit opened this issue Apr 29, 2020 · 0 comments

Comments

@tim-depthkit
Copy link

Calling setMeshScalar before loading a clip causes an error, so the only other way to do it is by setting this.meshScalar directly, which is supposed to be a "private" member.

This is an issue because using the default mesh scalar may cause some devices (iPhone, iPad, etc) to run out of memory before you have the opportunity to set it to something lower.

We should either update setMeshScalar to not attempt to rebuild geometry before a clip has been loaded, or add some other way to specify the default mesh scalar, in the constructor for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant