Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently fail to create output files when the specified output dir does not exist #14

Open
raymond-u opened this issue Jun 11, 2022 · 0 comments

Comments

@raymond-u
Copy link

Hello devs,

If I run "$ORNA -pair1 1.fa.gz -pair2 2.fa.gz -output test/test" in a folder where test/ does not exist, the program would silently fail, with no output files in test/. (And if run with added argument "-sorting 1", the program would complain about missing file in test/tmp/s0.fa.) This problem can be addressed by replacing mkdir() with a recursive one.

As a side note, I noticed that ORNA didn't try to remove *.h5 file when running in paired end mode, while it did do so in single end mode. I doubt if this is intentional since *.h5 is essentially a binary file.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant