Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test coverage needs improvement for the ./src/utils.jl file #868

Open
sivasathyaseeelan opened this issue Jan 1, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@sivasathyaseeelan
Copy link

Issue Description:

The file ./src/utils.jl currently has a low test coverage of 30.77%, which increases the risk of undetected issues in the codebase. This issue emphasizes the need to add comprehensive unit tests for the file.

Objective:

Improve the test coverage for ./src/utils.jl by writing and integrating robust unit tests.

Details:

Develop tests to validate the functionality of the code.
Address edge cases and ensure appropriate error handling is tested.
Integrate the new tests into the existing test suite for seamless execution.

For reference, see the current file on Codecov.

@sivasathyaseeelan sivasathyaseeelan added the bug Something isn't working label Jan 1, 2025
@Vaibhavdixit02
Copy link
Member

Happy to take a PR that improves the coverage

@ChrisRackauckas
Copy link
Member

I don't think that's quite it. The issue is that the tests are split into many groups https://github.com/SciML/Optimization.jl/blob/master/.github/workflows/CI.yml#L22-L38 and I don't think the codecov system is merging them all right. There's some optimizers for example that are not in the core tests but in the lib tests that are clearly used but not in the coverage, so that is pointing to some kind of issue with the merging.

@sivasathyaseeelan
Copy link
Author

I don't think that's quite it. The issue is that the tests are split into many groups https://github.com/SciML/Optimization.jl/blob/master/.github/workflows/CI.yml#L22-L38 and I don't think the codecov system is merging them all right. There's some optimizers for example that are not in the core tests but in the lib tests that are clearly used but not in the coverage, so that is pointing to some kind of issue with the merging.

Yes I also think the core functions which are tested in lib tests are not covered by codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants