Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample mesh plotting code has broken #5500

Closed
pp-mo opened this issue Sep 15, 2023 · 2 comments
Closed

Sample mesh plotting code has broken #5500

pp-mo opened this issue Sep 15, 2023 · 2 comments
Labels
Stale A stale issue/pull-request Type: Bug

Comments

@pp-mo
Copy link
Member

pp-mo commented Sep 15, 2023

🐛 Bug Report

How To Reproduce

Steps to reproduce the behaviour:

  1. copy the sample code from the UserGuide examples in "further_topics/ugrid/operations#load" and "further_topics/ugrid/operations#plotting"
  2. insert an unstructured netCDF/UGRID test file, such as "iris-sample-data:mesh_C4_synthetic_float.nc"
  3. run the code to produce a plot

Expected behaviour

Code should be self-contained, and it should run

Problems

  • Primarily, the from geovista.common import to_xyz line is now failing, since this geovista routine now got renamed to "geovista.common.to_cartesian"
  • Secondarily, the resulting plot is now near-empty because the coarse data is obscured by the base_layer (e.g. a radius change is needed to avoid one obscuring the other). It's not clear whether this changed, or maybe did not occur with the data used in the original (we don't know what that was)

There are obviously also some related strategic problems which this highlights:

  • the example is not run, so no way to spot when it goes stale (and in this case, now hits an exception)
  • the example is not self-contained, so you can't simply "run it" anyway -- and neither can a user
Copy link
Contributor

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue/pull-request label Jan 28, 2025
@trexfeathers
Copy link
Contributor

I think #5740 took care of this. @pp-mo please re-open if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale A stale issue/pull-request Type: Bug
Projects
Status: Done
Development

No branches or pull requests

2 participants