-
Notifications
You must be signed in to change notification settings - Fork 13
Fix a few issues with the CI #361
Conversation
…lags for clang-tidy
Following @slava77's suggestions I moved the format and check targets to the makefile in the SDL directory, which seems more appropriate. I also included more flags to clang-tidy to match the ones used during compilation. I had to make a modification to the suggested command to collect the include paths since including one of those paths caused a bunch of errors. There is an equivalent path, but with a "fixed" suffix, which works well. I considered producing a |
I made one last change. I'm currently testing producing comparison plots in the CMSSW workflow, but since it takes so long that the initial token that is generated in the job fails to be revoked at the end. So I modified it so that it no longer attempts to revoke it. |
just to be sure, before pushing the "merge"; is that test passing now? |
I just pushed the last changes to the TrackLooper-actions repo, so it's all ready now. Everything is working in the test repo, so it should work here too. |
I fixed a few issues that came up after the CI was implemented. Here they are:
clang-tidy
defaults to interpreting.h
files as C code. The action used to run this check does not allow enough control over the command that is run to specify the right parameters. This issue is also not solved by a standardcompile_commands.json
compilation database since it typically only contains commands for.cc
files. This was solved by using thecompdb
python package to also generate compilation commands for headers.clang-format
andclang-tidy
was 12, but now it was set to 16 to match the version in CMSSW 13_3_0.git
command, so it should be completely accurate.There was also the issue of the linter not being able to post comments. I'm not sure why that is happening, but I found online that turning actions off and on again might solve this issue. I did this, so hopefully it will work now.
I will also update the CMSSW workflow so that it produces comparison plots instead of just validation plots. But that is all done in TrackLooper-actions so no changes need to be made here.