Endcap Orientation Load Failure

[GNiendorf]

I think there is an error on the master branch. The code expects that the centroid values are attached to the endcap orientation file, see below.

TrackLooper/SDL/EndcapGeometry.cc

Lines 51 to 62 in 78d8d24

	ss >> detid >> avgr2 >> yl >> sl >> yh >> sh >> cr >> cp >> cz;
	// std::cout << " detid: " << detid << " avgr2: " << avgr2 << " yl: " << yl << " sl: " << sl << " yh: " << yh << " sh: " << sh << std::endl;
	avgr2s_[detid] = avgr2;
	yls_[detid] = yl;
	sls_[detid] = sl;
	yus_[detid] = yh;
	sus_[detid] = sh;
	centroid_rs_[detid] = cp;
	centroid_phis_[detid] = cr;
	centroid_zs_[detid] = cz;

But if you look at the file the master branch is using,

TrackLooper/SDL/LST.cc

Line 18 in 78d8d24

TString::Format("%s/data/endcap_orientation_data_CMSSW_12_2_0_pre2.txt", trackLooperDir().Data()).Data());

TrackLooper/data/endcap_orientation_data_CMSSW_12_2_0_pre2.txt

Lines 1 to 3 in 78d8d24

	# detid average_r2s y_intercept_low_hits slope_low_hits y_intercept_high_hits slope_high_hits
	411591806 2220.16867469 -158.103584386 3.29655422422 -166.217904238 3.29655904166
	411591802 2224.28374024 -97.3598468111 1.87086918017 -102.356491661 1.87086915128

It doesn't have the centroid values appended and so it is filling those values with 0's. The centroid phi's are used in the endcap map, so those values are used by the algorithm.

[GNiendorf]

TrackLooper/SDL/Hit.h

Line 256 in 78d8d24

// Unclear why these are not in map, but CPU map returns phi = 0 for all exceptions.

This should be looked at again.

[GNiendorf]

TrackLooper/SDL/Hit.h

Line 256 in 78d8d24

// Unclear why these are not in map, but CPU map returns phi = 0 for all exceptions.

This should be looked at again.

I just checked and it doesn't seem like this is run anymore, so the if statement can be removed.

Edit: This will be removed in #374