This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
more correct pt definition in writing out ntuples #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related slides showing the summary of this study |
|
/run standalone |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. |
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All Tracks
The full set of validation and comparison plots can be found here. |
|
/run standalone |
|
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original writing out ntuples is not a good estimation of the object pt, and we would prefer to use the pLS pt for pT3 and pT5 objects. Use pt from innerRadius to calculate the T5 pt in the output definition, instead of calculating from inner T3 and outer T3 "beta"s. This slide shows that, in the reco tracks that are matched to true track, the new pt have a smaller difference to the sim_pt compared to master.
On the other hand, there is still room to improve. We see that in the pT5, average over pLS pt and T5 inner radius pt has better resolution than only using pLS pt. We want to also test this on pT3. Then we realize that the radius of T3s aer not defined in the algorithm until we build a T5, which is not optimal and cannot be taken out as the T3 pt. This would come in a later PR to move the T3 radius calculation earlier, so that the output pt of pT3 can change accordingly.