Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw exception from axis-angle if axis is zero #15

Open
airballking opened this issue Nov 16, 2016 · 1 comment
Open

throw exception from axis-angle if axis is zero #15

airballking opened this issue Nov 16, 2016 · 1 comment
Assignees
@airballking
Labels
enhancement

Comments

@airballking
Copy link
Member

Adrian passed ((0, 0, 0), 0) and receives a matrix of NaNs. Throw a runtime exception when the rotation axis has length zero.
@airballking airballking self-assigned this Nov 16, 2016
@airballking airballking mentioned this issue Nov 18, 2016
Open
@airballking
Copy link
Member Author

Update: The NaNs were caused because the old axis-angle did not support variable axes, which Adrian used. That is fixed. However, checking for a zero-axis is not yet covered, and might be hard because it would have to happen at runtime.

I still have to think about a possible fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@airballking airballking

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@airballking