Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update composer.json, add @dev to require-dev section #889

Closed
gesinn-it-ilm opened this issue Dec 21, 2024 · 1 comment
Closed

update composer.json, add @dev to require-dev section #889

gesinn-it-ilm opened this issue Dec 21, 2024 · 1 comment
Assignees
Labels

Comments

@gesinn-it-ilm
Copy link
Contributor

gesinn-it-ilm commented Dec 21, 2024

After PR #884 has been reverted, and dev-master removed from require section in composer.json, test coverage has dropped significantly for MW 1.40. In codecov it could be checked, from 45,50 % to only 7 %.

After logs are checked for the MW 1.40 in CI, althought it is green light, it is not the real picture. Support for MW 1.40 is failing, and definitely do not use dev-master, but latest version of SMW which is 4.2.0.
This is the error which indicates that:

Error: Call to undefined method BacklinkCache::clear()

This error is fixed on master, so it is clear that it still uses 4.2.0 SMW version.

Fix support for MW 1.40, possible solution is adding "mediawiki/semantic-media-wiki": "@dev" to require-dev section in composer.json.

@gesinn-it-ilm gesinn-it-ilm self-assigned this Dec 21, 2024
@gesinn-it-ilm
Copy link
Contributor Author

"mediawiki/semantic-media-wiki": "@dev" added to composer.json.
Now, CI is working as it should.
Codecov upload works good as well.
PR will be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant