Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Number is missing in NodeDataReceivedAsync & NodeBirthReceivedAsync #59

Open
ankitagojiya opened this issue Dec 5, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@ankitagojiya
Copy link

According to the Sparkplug specification, we must submit a REBIRTH request if we get a message out of order. However, the NodeData which we receive in the host application(using NodeDataReceivedAsync ) just includes metrics not sequence number.

image

@SeppPenner SeppPenner self-assigned this Dec 5, 2023
@SeppPenner
Copy link
Owner

Need to check this.

@ankitagojiya
Copy link
Author

Hello @SeppPenner
any updated on this .
Need this to implement reorder timeout functionality using this.

@SeppPenner
Copy link
Owner

Hello @SeppPenner any updated on this . Need this to implement reorder timeout functionality using this.

Sorry, I haven't started with this yet. The plan is to work on this today and tomorrow.

@SeppPenner SeppPenner added the enhancement New feature or request label Feb 20, 2024
@SeppPenner
Copy link
Owner

Do you want this to be within the list of metrics or do you want to have this as seperate property like I did it in 611afa9?

@SeppPenner
Copy link
Owner

This should be fixed in version > 1.3.5+. Check 9cb2deb that implicitely fixed this.

@ankitagojiya
Copy link
Author

Hello @SeppPenner
Thanks for the above updates.
I have verified it in the latest release (1.3.8) but i am still not getting Seq Number in NBIRTH or NDATA event. For the clarification i am referring to Seq number like below image not the bdseq(sessionNumber) metrics.

image

@SeppPenner
Copy link
Owner

Hello @SeppPenner Thanks for the above updates. I have verified it in the latest release (1.3.8) but i am still not getting Seq Number in NBIRTH or NDATA event. For the clarification i am referring to Seq number like below image not the bdseq(sessionNumber) metrics.

image

Thanks for the clearification, need to check this.

@SeppPenner SeppPenner reopened this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants