Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the inclusion bdSeq metric on ncmd/dcmd optional #82

Open
joosttissen opened this issue Mar 7, 2024 · 1 comment
Open

Make the inclusion bdSeq metric on ncmd/dcmd optional #82

joosttissen opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@joosttissen
Copy link

Ignition cannot handle the bdSeq on ncmd/dcmd messages, it's giving the following exceptions:
image

Reading the sparkplugB specs I can only find that the bdSeq metric MUST be included on BIRTH/NDEATH not on any other message type. I can see that there used to be an setting to exclude the bdSeq metric from other messages based on #13.

If you agree I would like to add this setting back in the current codebase. Let me know and I'll create a PR.

@SeppPenner
Copy link
Owner

I guess this is a bug with version 3 of Sparkplug now as the metric isn't allowed anymore, but I need to check the specs again.

@SeppPenner SeppPenner self-assigned this Mar 7, 2024
@SeppPenner SeppPenner added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants