Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink triangular matrix handling #9

Open
Ulfgard opened this issue Sep 10, 2017 · 2 comments
Open

Rethink triangular matrix handling #9

Ulfgard opened this issue Sep 10, 2017 · 2 comments

Comments

@Ulfgard
Copy link
Member

Ulfgard commented Sep 10, 2017

the only thing distinguishing those two is how they are stored in the backend, i.e. this is a pure implementation detail which should not have an effect on the default implementation - they should be exactly the same. also there should not be any logic in the expression classes regarding this distinction

@Ulfgard
Copy link
Member Author

Ulfgard commented Sep 10, 2017

i just realized that this is not the case - at least for the block implementation which can make use of the dense storage. Still, it feels wrong to have a distinction on the level of expressions.

@Ulfgard
Copy link
Member Author

Ulfgard commented Sep 10, 2017

one example of where this fails is when we have C=A % T where T is triangular. The kernels are perfectly capable of doing this via trans(C) = trans(T) % trans(A), however, on expression level this logic is not implemented, so this will fail.

@Ulfgard Ulfgard changed the title unify tpmv and trmv kernel routines Rethink triangular matrix handling Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant