Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about quadratic penalties #2

Open
KaraLuo opened this issue Dec 8, 2017 · 2 comments
Open

Question about quadratic penalties #2

KaraLuo opened this issue Dec 8, 2017 · 2 comments

Comments

@KaraLuo
Copy link

KaraLuo commented Dec 8, 2017

@ShibiHe
Hi, thanks for your great paper, and sorry to bother you.

In the paper, the upper bound and lower bound are incorporated into the algorithm via quadratic penalties. But I cannot find the implementation corresponding to these two quadratic penalties.

It seems that the loss function is defined in the init function of DeepQLearner class. Here no penalties are added.

And some main differences comparing with the original DQN codes are shown in _do_training function of OptimalityTightening class. I am not so sure what is the meaning of targets1 variable. And how can this implementation works as two quadratic penalties in paper?

Please correct me if I'm wrong, and thank you very much!!

@ShibiHe
Copy link
Owner

ShibiHe commented Dec 8, 2017

Hi, please refer to Explain part in the readme for details.

@KaraLuo
Copy link
Author

KaraLuo commented Dec 15, 2017

Thank you very much! Apologize for missing it... But I still don't know the reason to do so. Will this be convenient for implementation?

Thank you again! Very appreciate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants