Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding observability into the opened/closed states of the <Filters /> component #11327

Closed
MaxLeduc opened this issue Dec 12, 2023 · 4 comments

Comments

@MaxLeduc
Copy link

MaxLeduc commented Dec 12, 2023

Description

After developing a feature that includes the <Filters /> component we noticed that when the filter menu is opened we can still click on list items below the menu. This has lead users to click line items by accident when trying to close the menu by clicking away from it, which is very disruptive.

Would it be possible to consider adding observability into the <Filters /> component opened/closed states, for example by having onOpen and onClose function props. This would allow us to pass callbacks to that component and disable clicking on line items while the filters menu is opened.

@xtaraim
Copy link

xtaraim commented Dec 13, 2023

tester can we do along hh

Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

@MaxLeduc
Copy link
Author

Stil relevant AFAIK

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants