-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO-NOT-MERGE/internal-only] AppCard components (Apps in Admin team) #11933
Conversation
7c270d9
to
aecc738
Compare
/snapit |
🫰✨ Thanks @ryanschingeck! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240425162245" |
/snapit |
🫰✨ Thanks @ryanschingeck! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240425165556" |
d9443b8
to
4dc80e8
Compare
/snapit |
🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240425204850",
"@shopify/polaris": "0.0.0-snapshot-20240425204850",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240425204850",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240425204850" |
/snapit |
🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240425212953",
"@shopify/polaris": "0.0.0-snapshot-20240425212953",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240425212953",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240425212953" |
58bfe63
to
c22cbbf
Compare
c22cbbf
to
b556d1e
Compare
/snapit |
🫰✨ Thanks @ryanschingeck! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240426182155",
"@shopify/polaris": "0.0.0-snapshot-20240426182155",
"@shopify/polaris-tokens": "0.0.0-snapshot-20240426182155",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240426182155" |
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
WHY are these changes introduced?
https://github.com/Shopify/apps-in-admin/issues/2128
See component diagrams here: https://www.figma.com/file/Mv1OaVzpRn0uS23gE5EMTP/Shared-App-Card-UI-Diagrams?type=whiteboard&t=qc1SxVDzAEju4C08-0
Do not merge to @shopify/Polaris, team will be moving this to the internal-only repo soon
NOTE: I have not added docs/documentation yet, want to get feedback/review on overall structure first
Spin URL for Storybook demo: https://polaris.app-card-polaris.ryan-schingeck.us.spin.dev/?path=/story/all-components-appcardmetadata--no-description
Adds the following new components to Polaris to support our shared AppCard component:
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.md
with documentation changes