Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for parsing circular references #164

Closed
wants to merge 1 commit into from
Closed

Add test for parsing circular references #164

wants to merge 1 commit into from

Conversation

rwstauner
Copy link
Contributor

Currently fails with:

  1) Failure:
ProtoBoeuf::ParserCompatibilityTest#test_circular_messages [test/parser_compatibility_test.rb:362]:
Expected: ".CircularValue"
  Actual: ".Circular.CircularValue"

  2) Failure:
ProtoBoeuf::ASTCompatibility#test_circular_messages [test/parser_compatibility_test.rb:362]:
Expected: ".CircularValue"
  Actual: ".Circular.CircularValue"

@rwstauner
wip - Add (currently failing) test for parsing circular references
561be2d 
  1) Failure:
ProtoBoeuf::ParserCompatibilityTest#test_circular_messages [test/parser_compatibility_test.rb:362]:
Expected: ".CircularValue"
  Actual: ".Circular.CircularValue"

  2) Failure:
ProtoBoeuf::ASTCompatibility#test_circular_messages [test/parser_compatibility_test.rb:362]:
Expected: ".CircularValue"
  Actual: ".Circular.CircularValue"
@rwstauner rwstauner changed the title wip - Add (currently failing) test for parsing circular references Add test for parsing circular references Jan 2, 2025
@rwstauner
Copy link
Contributor Author

I forgot we had this issue about it:
#127

@rwstauner
Copy link
Contributor Author

rwstauner commented Jan 16, 2025 •
edited by nirvdrum
Loading

This PR is obsoleted by #168.

@rwstauner rwstauner closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rwstauner