Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BillingConfigItem for v3 still requires future flags to use lineItemBilling #2000

Open
TravFitz opened this issue Jan 22, 2025 · 1 comment
Open

BillingConfigItem for v3 still requires future flags to use lineItemBilling #2000

TravFitz opened this issue Jan 22, 2025 · 1 comment

Comments

@TravFitz
Copy link

This is caused by the code defaulting to the BillingConfigLegacyItem if the flag isn't present, but it isn't an option in v3 and is a requirement.

This is causing my jest testing to go haywire because the types don't match. Is it worth removing the Future for BillingConfigItem in v3?
@lizkenyon
Copy link
Contributor

Hi 👋

Thanks for the flag. I will bring this to the team to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lizkenyon @TravFitz