Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increment_version_number_in_xcodeproj results in unwanted project file changes #109

Open
matrejek opened this issue Dec 9, 2024 · 1 comment

Comments

@matrejek
Copy link

matrejek commented Dec 9, 2024

I'm on fastlane-plugin-versioning (0.7.0) and fastlane 2.225.0.

I have defined a a simple lane to automate bumping patch version in my project. It's a part of an automated routine I would like to use to bump version, commit and create PR.

The lane looks like that:

  lane :patch_version_bump do |options|

    increment_version_number_in_xcodeproj(
      xcodeproj: projectFileName,
      bump_type: 'patch'
    )
end

However, the invocation results not only in changing the MARKETING_VERSION value but also changes comments on build plugins included from:

		FB44616F2C5A0D7600F86045 /* PBXTargetDependency */ = {
			isa = PBXTargetDependency;
			productRef = FB44616E2C5A0D7600F86045 /* SwiftLintPlugin */;
		};

to

		FB44616F2C5A0D7600F86045 /* PBXTargetDependency */ = {
			isa = PBXTargetDependency;
			productRef = FB44616E2C5A0D7600F86045 /* plugin:SwiftLintPlugin */;
		};

Is there a way to prevent that?

@jdouglas-nz
Copy link
Collaborator

jdouglas-nz commented Jan 2, 2025

hey @matrejek,
that is annoying!
as this gem doesn't do the actual project 'manipulation', it's preferable to wait until the 'upstream' Xcodeproj gem is fixed. Looks like someone else is removing that weird prefix in a PR here. I'll update this gem ASAP when it is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants