Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit all compilation pipelines to utilize reclaimer.util.is_valid_ascii_name_str #20

Open
MosesofEgypt opened this issue Dec 19, 2019 · 0 comments

Comments

@MosesofEgypt
Copy link
Contributor

Currently most(maybe all?) of the compilation pipelines will crash when trying to save a tag that was compiled from source files with non latin-1 characters in their filename. Use reclaimer.util.is_valid_ascii_name_str to determine and handle offending strings before they end up in the resulting tag. As latin-1 is an extended subset of ascii, that function will work how we need it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant