Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time to configure #139

Open
1 task done
alexkaiser opened this issue Nov 28, 2024 · 0 comments
Open
1 task done

Add time to configure #139

alexkaiser opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alexkaiser
Copy link

Use Case

Some LPN blocks such as the chamber block have time-dependent parameters, but explicit time-dependence is not implemented in the calibrate program.

Problem

This will allow blocks with time-dependent to be used by the calibrate program.

Solution

Time and time-dependent variables for each block should be updated in the calibrate program in the main loop over the time series.

Alternatives considered

The code could potentially be modified from the main solver loops over time.

Additional context

An initial attempt at adding chamber blocks to configure (that does not yet work) was thwarted by the lack of time-dependent updates. See this fork for (incomplete) code: https://github.com/alexkaiser/svZeroDSolver/tree/chamber_calibrate

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@alexkaiser alexkaiser added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant