From 753e040fe05b8a0aca099e3fd62220fb433c02f5 Mon Sep 17 00:00:00 2001 From: Ollie Curtis <8831547+olliecurtis@users.noreply.github.com> Date: Tue, 7 Jan 2025 16:59:46 +0000 Subject: [PATCH] [LOOM-2014]: Update form element corner radii (#3703) --- package-lock.json | 18 ++++++++++-------- package.json | 2 +- packages/bpk-mixins/_forms.scss | 3 +++ packages/package-lock.json | 28 ++++++++++++++++++---------- packages/package.json | 2 +- 5 files changed, 33 insertions(+), 20 deletions(-) diff --git a/package-lock.json b/package-lock.json index 65addf91da..944bccee28 100644 --- a/package-lock.json +++ b/package-lock.json @@ -22,7 +22,7 @@ "@babel/register": "^7.25.7", "@percy/cli": "^1.30.0", "@percy/storybook": "^6.0.1", - "@skyscanner/bpk-foundations-web": "^18.1.0", + "@skyscanner/bpk-foundations-web": "^19.1.0", "@skyscanner/bpk-svgs": "^20.0.0", "@skyscanner/eslint-config-skyscanner": "^18.2.0", "@skyscanner/stylelint-config-skyscanner": "^11.1.0", @@ -5188,10 +5188,11 @@ } }, "node_modules/@skyscanner/bpk-foundations-common": { - "version": "6.12.0", - "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-common/-/bpk-foundations-common-6.12.0.tgz", - "integrity": "sha512-YoNyWk7OuOiGZYowcrUx7AOxnKlGadzimfiSAAiGa08eqrQ1P7c9sxRiKjodvuVhy3xi9WMQWRe8Km64EnMHQQ==", + "version": "6.13.0", + "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-common/-/bpk-foundations-common-6.13.0.tgz", + "integrity": "sha512-+xjytyCEuyGQ2nB1ZElxmNaJwdYbP4kBBLmWGe6IRAFFkmCGtZwCzulfASTabX4KWxwo+he2E+CXCG5umMaFFg==", "dev": true, + "license": "Apache-2.0", "dependencies": { "color": "^4.2.3" } @@ -5210,12 +5211,13 @@ } }, "node_modules/@skyscanner/bpk-foundations-web": { - "version": "18.1.0", - "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-web/-/bpk-foundations-web-18.1.0.tgz", - "integrity": "sha512-h2wYfN8AEBQCZbje1PAueFdz9mlfCFNrZP4piXPPaROY3gOs3R+f6tcLofiHkFE+NexyzkFeBU9Boyo8vLRMXw==", + "version": "19.1.0", + "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-web/-/bpk-foundations-web-19.1.0.tgz", + "integrity": "sha512-mJedzF+kKEbb7hTCQ4AAilYGQ4RUAWg18iTzinlBbZyZR6qY7r+mC5g66yoWObc3iGgjfev2kV6JllhIyxoY7A==", "dev": true, + "license": "Apache-2.0", "dependencies": { - "@skyscanner/bpk-foundations-common": "^6.12.0", + "@skyscanner/bpk-foundations-common": "^6.13.0", "color": "^4.2.3" } }, diff --git a/package.json b/package.json index ede80d187c..e47aef6b9c 100644 --- a/package.json +++ b/package.json @@ -121,7 +121,7 @@ "@babel/register": "^7.25.7", "@percy/cli": "^1.30.0", "@percy/storybook": "^6.0.1", - "@skyscanner/bpk-foundations-web": "^18.1.0", + "@skyscanner/bpk-foundations-web": "^19.1.0", "@skyscanner/bpk-svgs": "^20.0.0", "@skyscanner/eslint-config-skyscanner": "^18.2.0", "@skyscanner/stylelint-config-skyscanner": "^11.1.0", diff --git a/packages/bpk-mixins/_forms.scss b/packages/bpk-mixins/_forms.scss index 1e4cde07e3..8a6f910dc9 100644 --- a/packages/bpk-mixins/_forms.scss +++ b/packages/bpk-mixins/_forms.scss @@ -231,6 +231,7 @@ height: $bpk-input-large-height; padding-right: bpk-spacing-base(); padding-left: bpk-spacing-base(); + border-radius: $bpk-input-large-border-radius; &.bpk-input--valid, &.bpk-input--invalid, @@ -402,6 +403,7 @@ height: $bpk-input-large-height; padding: bpk-spacing-md() bpk-spacing-base(); padding-right: bpk-spacing-xxl(); + border-radius: $bpk-select-large-border-radius; background: $bpk-surface-default-day url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCIgd2lkdGg9IjE2IiBoZWlnaHQ9IjE2Ij48c3R5bGUgdHlwZT0idGV4dC9jc3MiPmNpcmNsZSwgZWxsaXBzZSwgbGluZSwgcGF0aCwgcG9seWdvbiwgcG9seWxpbmUsIHJlY3QsIHRleHQgeyBmaWxsOiAjMTYxNjE2ICFpbXBvcnRhbnQgfTwvc3R5bGU+PHBhdGggZD0iTTE2LjUzNyA4LjI1SDcuNDYzYTEuMzU4IDEuMzU4IDAgMCAwLTEuMTEgMi4yNTFsNC4zNTQgNC43N2ExLjUzIDEuNTMgMCAwIDAgMi4xODQuMDRsNC43MTgtNC43N2ExLjM1NyAxLjM1NyAwIDAgMC0xLjA3Mi0yLjI5MXoiLz48L3N2Zz4=') no-repeat right bpk-spacing-base() center; @@ -1049,6 +1051,7 @@ min-height: 6 * bpk-spacing-base(); padding-right: bpk-spacing-base(); padding-left: bpk-spacing-base(); + border-radius: $bpk-input-large-border-radius; &.bpk-textarea--invalid { padding-right: bpk-spacing-xxl(); diff --git a/packages/package-lock.json b/packages/package-lock.json index bece903f66..861a546a1b 100644 --- a/packages/package-lock.json +++ b/packages/package-lock.json @@ -14,7 +14,7 @@ "@radix-ui/react-compose-refs": "^1.1.0", "@radix-ui/react-slider": "^1.1.2", "@react-google-maps/api": "^2.19.3", - "@skyscanner/bpk-foundations-web": "^18.1.0", + "@skyscanner/bpk-foundations-web": "^19.1.0", "@skyscanner/bpk-svgs": "^20.0.0", "a11y-focus-scope": "^1.1.3", "a11y-focus-store": "^1.0.0", @@ -469,19 +469,21 @@ "integrity": "sha512-x9ibmsP0ZVqzyCo1Pitbw+4b6iEXRw/r1TCy3vOUR3eKrzWLnHYZMR325BkZW2r8fnuWE/V3Fp4QZOP9qYORCw==" }, "node_modules/@skyscanner/bpk-foundations-common": { - "version": "6.12.0", - "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-common/-/bpk-foundations-common-6.12.0.tgz", - "integrity": "sha512-YoNyWk7OuOiGZYowcrUx7AOxnKlGadzimfiSAAiGa08eqrQ1P7c9sxRiKjodvuVhy3xi9WMQWRe8Km64EnMHQQ==", + "version": "6.13.0", + "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-common/-/bpk-foundations-common-6.13.0.tgz", + "integrity": "sha512-+xjytyCEuyGQ2nB1ZElxmNaJwdYbP4kBBLmWGe6IRAFFkmCGtZwCzulfASTabX4KWxwo+he2E+CXCG5umMaFFg==", + "license": "Apache-2.0", "dependencies": { "color": "^4.2.3" } }, "node_modules/@skyscanner/bpk-foundations-web": { - "version": "18.1.0", - "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-web/-/bpk-foundations-web-18.1.0.tgz", - "integrity": "sha512-h2wYfN8AEBQCZbje1PAueFdz9mlfCFNrZP4piXPPaROY3gOs3R+f6tcLofiHkFE+NexyzkFeBU9Boyo8vLRMXw==", + "version": "19.1.0", + "resolved": "https://registry.npmjs.org/@skyscanner/bpk-foundations-web/-/bpk-foundations-web-19.1.0.tgz", + "integrity": "sha512-mJedzF+kKEbb7hTCQ4AAilYGQ4RUAWg18iTzinlBbZyZR6qY7r+mC5g66yoWObc3iGgjfev2kV6JllhIyxoY7A==", + "license": "Apache-2.0", "dependencies": { - "@skyscanner/bpk-foundations-common": "^6.12.0", + "@skyscanner/bpk-foundations-common": "^6.13.0", "color": "^4.2.3" } }, @@ -517,6 +519,7 @@ "version": "4.2.3", "resolved": "https://registry.npmjs.org/color/-/color-4.2.3.tgz", "integrity": "sha512-1rXeuUUiGGrykh+CeBdu5Ie7OJwinCgQY0bc7GCRxy5xVHy+moaqkpL/jqQq0MtQOeYcrqEz4abc5f0KtU7W4A==", + "license": "MIT", "dependencies": { "color-convert": "^2.0.1", "color-string": "^1.9.0" @@ -529,6 +532,7 @@ "version": "2.0.1", "resolved": "https://registry.npmjs.org/color-convert/-/color-convert-2.0.1.tgz", "integrity": "sha512-RRECPsj7iu/xb5oKYcsFHSppFNnsj/52OVTRKb4zP5onXwVF3zVmmToNcOfGC+CRDpfK/U584fMg38ZHCaElKQ==", + "license": "MIT", "dependencies": { "color-name": "~1.1.4" }, @@ -539,12 +543,14 @@ "node_modules/color-name": { "version": "1.1.4", "resolved": "https://registry.npmjs.org/color-name/-/color-name-1.1.4.tgz", - "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==" + "integrity": "sha512-dOy+3AuW3a2wNbZHIuMZpTcgjGuLU/uBL/ubcZF9OXbDo8ff4O8yVp5Bf0efS8uEoYo5q4Fx7dY9OgQGXgAsQA==", + "license": "MIT" }, "node_modules/color-string": { "version": "1.9.1", "resolved": "https://registry.npmjs.org/color-string/-/color-string-1.9.1.tgz", "integrity": "sha512-shrVawQFojnZv6xM40anx4CkoDP+fZsw/ZerEMsW/pyzsRbElpsL/DBVW7q3ExxwusdNXI3lXpuhEZkzs8p5Eg==", + "license": "MIT", "dependencies": { "color-name": "^1.0.0", "simple-swizzle": "^0.2.2" @@ -686,7 +692,8 @@ "node_modules/is-arrayish": { "version": "0.3.2", "resolved": "https://registry.npmjs.org/is-arrayish/-/is-arrayish-0.3.2.tgz", - "integrity": "sha512-eVRqCvVlZbuw3GrM63ovNSNAeA1K16kaR/LRY/92w0zxQ5/1YzwblUX652i4Xs9RwAGjW9d9y6X88t8OaAJfWQ==" + "integrity": "sha512-eVRqCvVlZbuw3GrM63ovNSNAeA1K16kaR/LRY/92w0zxQ5/1YzwblUX652i4Xs9RwAGjW9d9y6X88t8OaAJfWQ==", + "license": "MIT" }, "node_modules/js-tokens": { "version": "4.0.0", @@ -901,6 +908,7 @@ "version": "0.2.2", "resolved": "https://registry.npmjs.org/simple-swizzle/-/simple-swizzle-0.2.2.tgz", "integrity": "sha512-JA//kQgZtbuY83m+xT+tXJkmJncGMTFT+C+g2h2R9uxkYIrE2yy9sgmcLhCnw57/WSD+Eh3J97FPEDFnbXnDUg==", + "license": "MIT", "dependencies": { "is-arrayish": "^0.3.1" } diff --git a/packages/package.json b/packages/package.json index 8d8b2df27b..c99f37acec 100644 --- a/packages/package.json +++ b/packages/package.json @@ -27,7 +27,7 @@ "@radix-ui/react-compose-refs": "^1.1.0", "@radix-ui/react-slider": "^1.1.2", "@react-google-maps/api": "^2.19.3", - "@skyscanner/bpk-foundations-web": "^18.1.0", + "@skyscanner/bpk-foundations-web": "^19.1.0", "@skyscanner/bpk-svgs": "^20.0.0", "a11y-focus-scope": "^1.1.3", "a11y-focus-store": "^1.0.0",