Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Overlay] Use standing space #185

Open
TheButlah opened this issue Feb 12, 2023 · 4 comments
Open

[Overlay] Use standing space #185

TheButlah opened this issue Feb 12, 2023 · 4 comments
Assignees
Labels
Area: Overlay Relating to the SteamVR Overlay subproject Priority: High
Milestone

Comments

@TheButlah
Copy link
Collaborator

We had changes in SlimeVR/SlimeVR-OpenVR-Driver#24 that switched the tracking space from raw to "standing". We need to account for this change in the overlay.

@TheButlah TheButlah added Area: Overlay Relating to the SteamVR Overlay subproject Priority: High labels Feb 12, 2023
@TheButlah TheButlah added this to the v1.0 milestone Feb 12, 2023
@TheButlah TheButlah changed the title [Overlay] Fix the overlay to align to the first person perspective [Overlay] Use standing space Feb 12, 2023
@TheButlah
Copy link
Collaborator Author

TheButlah commented Feb 12, 2023

Mentioning @kitlith in case he wants to tackle this

@kitlith
Copy link
Member

kitlith commented Feb 12, 2023

some of the PRs made to ovr_overlay are necessary for this. (you may as well just assign me for this)

overlay has already been switched to standing, but everything else is now using a variant that ignores playspace movement, which is why changes are still necessary

@TheButlah
Copy link
Collaborator Author

some of the PRs made to ovr_overlay are necessary for this.

Working on reviewing them. Could you link the ones that block this issue?

@kitlith
Copy link
Member

kitlith commented Feb 12, 2023

TheButlah/ovr_overlay#8 and TheButlah/ovr_overlay#9, though the first one needs to be rebased and worked on a bit now that you merged TheButlah/ovr_overlay#11

I'll get that rebased now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Overlay Relating to the SteamVR Overlay subproject Priority: High
Projects
None yet
Development

No branches or pull requests

2 participants