forked from leandrotsampa/gst-omx-hisilicon
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathChangeLog
6599 lines (4778 loc) · 226 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
=== release 1.14.5 ===
2019-05-29 18:10:58 +0100 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.5
2018-05-18 10:53:34 +0200 Guillaume Desmottes <[email protected]>
* examples/egl/testegl.c:
testelg: include eglext.h
Neded for the declaration of eglSaneChooseConfigBRCM().
2018-05-18 10:38:33 +0200 Guillaume Desmottes <[email protected]>
* examples/egl/testegl.c:
testegl: move up pi specific macros
We need to define __VCCOREVER__ and disable redundant-decls before
including the egl.h from the pi.
2018-11-05 05:43:43 +0000 Matthew Waters <[email protected]>
* .gitmodules:
* gst-omx.doap:
Update git locations to gitlab
2018-07-26 16:22:50 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: fix pool caps reference stealing
gst_buffer_pool_config_get_params() doesn't ref the returning caps;
so gst_caps_replace() was unreffing the reference owned by the pool.
https://bugzilla.gnome.org/show_bug.cgi?id=796918
=== release 1.14.4 ===
2018-10-02 23:15:11 +0100 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.4
=== release 1.14.3 ===
2018-09-16 16:42:48 +0100 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.3
2018-08-22 15:56:18 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: wait for flush complete and buffers being released when flushing
When flusing we should wait for OMX to send the flush command complete event
AND all ports being released.
We were stopping as soon as one of those condition was met.
Fix a race between FillThisBufferDone/EmptyBufferDone and the flush
EventCmdComplete messages. The OMX implementation is supposed to release
its buffers before posting the EventCmdComplete event but the ordering
isn't guaranteed as the FillThisBufferDone/EmptyBufferDone and
EventHandler callbacks can be called from different threads (cf 2.7
'Thread Safety' in the spec).
Only wait for buffers currently used by OMX as some buffers may not be
in the pending queue because they are held downstream.
https://bugzilla.gnome.org/show_bug.cgi?id=789475
2018-08-22 15:52:23 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: factor out should_wait_until_flushed()
No semantic change. Makes the code easier to understand and I'm about to
change the waiting condition.
https://bugzilla.gnome.org/show_bug.cgi?id=789475
=== release 1.14.2 ===
2018-07-20 01:09:29 +0100 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.2
2018-04-20 11:54:14 +0100 Tim-Philipp Müller <[email protected]>
* meson.build:
meson: fix miscellaneous meson warnings
cc.has_header*() doesn't have a 'required:' kwarg.
=== release 1.14.1 ===
2018-05-17 13:37:19 +0100 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.1
2018-04-18 12:42:55 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
omxvideoenc/dec: fix handling of component enabling failing
- Report the error from OMX if any (OMX_EventError)
- If not report the failing to the application (GST_ELEMENT_ERROR)
- return GST_FLOW_ERROR rather than FALSE
- don't leak @frame
https://bugzilla.gnome.org/show_bug.cgi?id=795352
2018-03-14 14:53:50 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
log_omx_performance: convert pointers to strings
G_TYPE_POINTER are not serialized in logs.
https://bugzilla.gnome.org/show_bug.cgi?id=794331
2018-04-02 15:14:51 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: remove duplicated debug message
We already have the exact same message at the beginning of
gst_omx_video_enc_handle_frame(). Having it twice is confusing when
reading/grepping logs.
I kept the earlier one to keep the symetry with
gst_omx_video_dec_handle_frame().
https://bugzilla.gnome.org/show_bug.cgi?id=794897
2018-02-22 11:27:03 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: add 'roi' qp-mode on zynqultrascaleplus
New QP mode used to handle ROI metadata.
https://bugzilla.gnome.org/show_bug.cgi?id=793696
=== release 1.14.0 ===
2018-03-19 20:31:02 +0000 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.14.0
=== release 1.13.91 ===
2018-03-13 19:32:39 +0000 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.13.91
2018-03-09 12:02:29 +0000 Tim-Philipp Müller <[email protected]>
* meson.build:
meson: fix typo in package name define
2018-02-27 15:42:53 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxh265enc.c:
* omx/gstomxh265utils.c:
omxh265: update 422 profile names
h265parse is gaining support for the format range extension profile
(bgo#793876).
Use the profile names defined in h265parse.
https://bugzilla.gnome.org/show_bug.cgi?id=793928
2018-03-05 13:49:18 -0500 Nicolas Dufresne <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: Don't drop the frame on empty payload
This otherwise may lead to "No reference frame found" warning.
2018-03-01 15:16:55 -0500 Nicolas Dufresne <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: Don't drop the frame on empty payload
This otherwise may lead to "No reference frame found" warning.
2018-03-02 15:36:06 -0500 Nicolas Dufresne <[email protected]>
* omx/gstomx.c:
omx: Free empty buffers list in use_dynamic_buffers
To indicate we are doing dynamic buffers importation, we pass
a list of NULL pointers, but we forgot to free that list.
2018-03-01 15:16:32 -0500 Nicolas Dufresne <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: Fix CodecState leak
=== release 1.13.90 ===
2018-03-03 23:00:59 +0000 Tim-Philipp Müller <[email protected]>
* ChangeLog:
* NEWS:
* RELEASE:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.13.90
2018-03-03 20:21:06 +0000 Tim-Philipp Müller <[email protected]>
* config/Makefile.am:
config: dist tizonia config files
2018-03-02 11:06:08 -0500 Nicolas Dufresne <[email protected]>
* omx/gstomx.c:
Revert "omx: wait for flush complete and buffers being released when flushing"
This reverts commit 4211e4c29a262f110cb92ddf9c06b403ced233ef.
2018-02-21 12:50:42 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
videoenc: don't set stride padding to 0 when copying frames
Padding can be left undefined there is no point filling it with 0.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
2018-02-16 11:50:35 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxbufferpool.c:
* omx/gstomxh264enc.c:
* omx/gstomxh265enc.c:
* omx/gstomxvideo.c:
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
add support for NV12_10LE32 and NV16_10LE32 on zynqultrascaleplus
The encoder and decoder on zynqultrascaleplus support these new 10 bits
format.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
2018-02-16 11:46:47 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: factor out gst_omx_video_enc_nv12_manual_copy()
No semantic change, I'm going to re-use it to copy the NV12_10LE32
format.
https://bugzilla.gnome.org/show_bug.cgi?id=793694
2018-01-17 10:40:49 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: display the computed buffer size when configuring input
https://bugzilla.gnome.org/show_bug.cgi?id=793694
2018-02-06 14:25:57 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
* omx/gstomxvideoenc.h:
videoenc: implement ROI on zynqultrascaleplus
Check input buffers for ROI meta and pass them to the encoder by using
zynqultrascaleplus's custom OMX extension. Also add a new
"default-roi-quality" in order to tell the encoder what quality level
should be applied to ROI by default.
https://bugzilla.gnome.org/show_bug.cgi?id=793696
2018-02-14 17:23:39 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: remove GST_PARAM_MUTABLE_PLAYING from 'max-bitrate' property
This property isn't actually mutable in the PLAYING state.
https://bugzilla.gnome.org/show_bug.cgi?id=793458
2018-02-14 17:20:02 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
* omx/gstomxvideoenc.h:
omxvideoenc: protect target_bitrate with the object lock
The 'target-bitrate' property can be changed while PLAYING
(GST_PARAM_MUTABLE_PLAYING). Make it thread-safe to prevent concurrent
accesses between the application and streaming thread.
https://bugzilla.gnome.org/show_bug.cgi?id=793458
2018-02-20 11:46:49 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxbufferpool.c:
omxbufferpool: add PERFORMANCE DEBUG message when copying output frames
I spent quiet some time figuring out why performance of my pipeline were
terrible. Turned out it was because of output frames being copied
because of stride/offset mismatch.
Add a PERFORMANCE DEBUG message to make it easier to spot and debug from logs.
https://bugzilla.gnome.org/show_bug.cgi?id=793637
2018-02-15 19:44:37 +0000 Tim-Philipp Müller <[email protected]>
* configure.ac:
* meson.build:
Back to development
=== release 1.13.1 ===
2018-02-15 17:50:14 +0000 Tim-Philipp Müller <[email protected]>
* Makefile.am:
* NEWS:
* configure.ac:
* gst-omx.doap:
* meson.build:
Release 1.13.1
2017-06-30 15:15:06 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxh265enc.c:
omxh265enc: fix typo in "periodicty-idr" property name
Also fix the 'nick' of the property.
omxh265enc is based on the code from omxh264enc and suffers the same
typo as we fixed in https://bugzilla.gnome.org/show_bug.cgi?id=784370
This element isn't part of a stable release yet so it's not an API
break.
https://bugzilla.gnome.org/show_bug.cgi?id=793390
2018-02-08 19:18:59 +0000 Tim-Philipp Müller <[email protected]>
* meson.build:
meson: make version numbers ints and fix int/string comparison
WARNING: Trying to compare values of different types (str, int).
The result of this is undefined and will become a hard error
in a future Meson release.
Also remove unused libversion/soversion.
2017-12-12 16:50:00 +0100 Guillaume Desmottes <[email protected]>
* configure.ac:
* meson.build:
* omx/gstomx.h:
include all OMX extension headers if present
The OMX specs defines 8 headers that implementations can use to define
their custom extensions. We were checking and including 3 and ignoring
the other ones.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
2018-01-30 10:31:03 +0100 Guillaume Desmottes <[email protected]>
* meson.build:
* omx/meson.build:
* tools/meson.build:
meson: simplify OMX extensions detection
We are now always checking which files are present or not, even when using our
internal copy of OMX, rather than hardcoding the ones present in it.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
2018-01-30 11:54:24 +0000 Nicolas Dufresne <[email protected]>
* meson.build:
* omx/meson.build:
* tools/meson.build:
Revert "meson: use include_directories() with external OMX headers path"
This reverts commit 9d37a92a615e54e8ee12f8c65bcfe386ec9de2d0.
2017-11-27 14:52:10 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxh265enc.c:
* omx/gstomxh265enc.h:
omxh265enc: add some encoding properties
constrained-intra-prediction and loop-filter-mode.
Those map standard OMX settings.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
2017-11-23 15:54:15 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxh264enc.c:
* omx/gstomxh264enc.h:
omxh264enc: add some encoding properties
entropy-mode, constrained-intra-prediction and loop-filter-mode.
Those map standard OMX settings.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
2017-06-08 12:31:21 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
* omx/gstomxvideoenc.h:
omxvideoenc: add zynqultrascaleplus specific properties
https://bugzilla.gnome.org/show_bug.cgi?id=792528
2017-10-31 12:24:39 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: document unit of target-bitrate property
nTargetBitrate and nEncodeBitrate are defined in bits per second in the
OMX spec.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
2017-07-06 10:18:48 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideodec.h:
omxvideodec: add internal-entropy-buffers property on zynqultrascaleplus
Custom property to control the number of internal buffers used in the
decoder to smooth out entropy decoding performance.
https://bugzilla.gnome.org/show_bug.cgi?id=792528
2018-01-30 10:31:03 +0100 Guillaume Desmottes <[email protected]>
* meson.build:
* omx/meson.build:
* tools/meson.build:
meson: use include_directories() with external OMX headers path
It seems cleaner to use the proper meson tools to include this path
rather than manually tweak the build flags.
This also allows us to simplify the OMX extensions detection code. We
are now always checking which files are present, even when using our
internal copy of OMX, rather than hardcoding the ones present in it.
https://bugzilla.gnome.org/show_bug.cgi?id=792043
2017-11-07 15:09:35 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: expose chroma format and bit depth in output caps
As we added in the parser (bgo#792039) expose the chroma and bit
depth information in output caps.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
2017-11-07 14:30:45 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: factor out get_output_caps()
No semantic change so far.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
2017-12-29 11:59:36 +0100 Guillaume Desmottes <[email protected]>
* config/zynqultrascaleplus/gstomx.conf:
* omx/gstomx.c:
* omx/gstomx.h:
* omx/gstomxvideodec.c:
omxvideodec: add hack to pass color format from caps to OMX decoder
This hack tries to pass as much information as possible from caps to the
decoder before it receives any buffer. These information can be used by
the OMX decoder to, for example, pre-allocate its internal buffers
before starting to decode and so reduce its initial latency.
This mechanism is currently supported by the zynqultrascaleplus decoder.
https://bugzilla.gnome.org/show_bug.cgi?id=792040
2017-12-01 12:43:19 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
log failing OMX calls as errors
I find it confusing when debugging that OMX calls returning an error
where not logged as GST_LEVEL_ERROR making them harder to spot.
Fix this by introducing simple log macros checking the return value of
the OMX call and logging failures as errors.
https://bugzilla.gnome.org/show_bug.cgi?id=791069
2017-10-30 11:59:19 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
add OMX_PERFORMANCE debug category
Can be used to log buffers exchange between OMX and gst-omx to profile
performances of the OMX component.
Ideally this should be done using tracer hooks but it's currently not
possible to define custom hooks outside of core.
Use GST_DEBUG="OMX_PERFORMANCE:8" to enable it.
See also
https://github.com/gdesmott/gst-log-parser/blob/master/src/bin/omx-perf.rs
as a simple program consuming those logs to generate gnuplot files and
stats.
https://bugzilla.gnome.org/show_bug.cgi?id=791093
2017-07-27 11:21:59 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
* omx/gstomx.h:
* omx/gstomxvideoenc.c:
* omx/gstomxvideoenc.h:
omxvideoenc: implement dmabuf import on zynqultrascaleplus
The Zynq UltraScale+ encoder implements a custom OMX extension to
directly import dmabuf saving the need of mapping input buffers.
This can be use with either 'v4l2src io-mode=dmabuf' or an OMX video
decoder upstream.
https://bugzilla.gnome.org/show_bug.cgi?id=792361
2017-09-22 16:02:40 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: drop late input frames if QoS is enabled
Make use of the new GstVideoEncoder QoS API to drop late input frames. This may
help a live pipeline to catch up if it's being late and all frames end up
being dropped at the sink.
https://bugzilla.gnome.org/show_bug.cgi?id=792783
2018-01-19 15:18:23 +0530 Ashish Kumar <[email protected]>
* examples/egl/testegl.c:
TestEgl: Removed redundant/unused code
https://bugzilla.gnome.org/show_bug.cgi?id=788550
2018-01-03 16:07:18 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: early return in fill_buffer() if something goes wrong
If something goes wrong while trying to manually copy the input buffer,
the 'break' was moving us out of the 'for' loop but not out of the switch block.
So we ended up calling gst_video_frame_unmap() a second time (raising
assertions) and returning TRUE rather than FALSE.
Reproduced with a WIP zynqultrascaleplus OMX branch reporting wrong
buffer sizes and so triggering this bug.
https://bugzilla.gnome.org/show_bug.cgi?id=792167
2017-12-19 16:09:41 +0000 Tim-Philipp Müller <[email protected]>
* meson.build:
meson: gl: the winsys and platform list in the .pc file is space-separated
2017-12-19 16:08:58 +0000 Tim-Philipp Müller <[email protected]>
* meson.build:
meson: fix subproject fallback for gstreamer-gl-1.0
It's now in -base.
2017-12-12 17:30:27 +0000 Julien Isorce <[email protected]>
* omx/gstomxvideo.c:
* omx/gstomxvideo.h:
* omx/gstomxvideodec.c:
omxvideodec: ignore very little variations of the framerate
If less than 1%.
The dynamic format change should not happen when the
resolution does not change and when only the framerate
changes but very slightly, i.e. from 50000/1677=29.81
to 89/3=29.66 so a "percentage change" of less than 1%
(i.e. 100*(29.81-29.66)/29.66 = 0.50 < 1 ). In that case
just ignore it to avoid unnecessary renegotiation.
https://bugzilla.gnome.org/show_bug.cgi?id=759043
2017-08-09 12:07:33 -0400 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideodec.h:
omxvideodec: use dynamic buffer mode on input if possible
Prevent from copying the input buffers between GStreamer and OMX.
Tested on zynqultrascaleplus and rpi (without dynamic buffers).
https://bugzilla.gnome.org/show_bug.cgi?id=787093
2017-07-20 16:35:31 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
* omx/gstomxvideoenc.h:
omxvideoenc: use dynamic buffer mode on input if possible
If the OMX component supports dynamic buffer mode and the input buffers
are properly aligned avoid copying each input frame between OMX and
GStreamer.
Tested on zynqultrascaleplus and rpi (without dynamic buffers).
https://bugzilla.gnome.org/show_bug.cgi?id=787093
2017-07-20 12:56:37 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
omxvideoenc/dec: factor out input buffer allocation
No semantic change so far. I'm going to add an alternate way to allocate
input buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=787093
2017-07-20 16:31:54 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
* omx/gstomx.h:
omx: add API to implement dynamic buffers support
OMX 1.2.0 introduced a third way to manage buffers by allowing
components to only allocate buffers header during their initialization
and change their pBuffer pointer at runtime.
This new feature can save us a copy between GStreamer and OMX for each
input buffer.
This patch adds API to allocate and use such buffers.
https://bugzilla.gnome.org/show_bug.cgi?id=787093
2017-12-14 14:53:17 +1100 Matthew Waters <[email protected]>
* common:
Automatic update of common submodule
From e8c7a71 to 3fa2c9e
2017-12-13 12:06:40 +0000 Julien Isorce <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: consolidate the decision to try UseBuffer
The tee element can call gst_query_add_allocation_pool with pool as NULL.
Checking nth > 0 is not enough so we need to verify if there is a pool.
https://bugzilla.gnome.org/show_bug.cgi?id=730758
https://bugzilla.gnome.org/show_bug.cgi?id=784069
2017-12-12 14:45:30 +0000 Julien Isorce <[email protected]>
* omx/gstomxvideo.c:
* omx/gstomxvideo.h:
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
gstomxvideodec: fix framerate overflow
Some live streams can set the framerate to 50000/1677 (=29.81).
GstVideoInfo.fps_n << 16 is wrong if the fps_n is 50000
(i.e. greater than 32767).
https://bugzilla.gnome.org/show_bug.cgi?id=759043
2017-08-22 13:48:26 +0100 Julien Isorce <[email protected]>
* configure.ac:
* examples/egl/Makefile.am:
* examples/egl/meson.build:
* examples/egl/testegl.c:
* meson.build:
example: port testegl.c to desktop
Will be easier to maintain.
Also uniformize autotool build with meson build which is
already retrieving the gl libs.
https://bugzilla.gnome.org/show_bug.cgi?id=781606
2017-12-11 15:55:44 +0000 Julien Isorce <[email protected]>
* meson.build:
meson: move omx features check after target selection
And uses gst_omx_args instead of add_global_arguments.
Similar to c69232852120d064c689caef07b3c68ad8fe6288
which was only for configure.ac
Useful to get omxvp8dec with meson too:
meson . buildtmp -D with_omx_target=tizonia
https://bugzilla.gnome.org/show_bug.cgi?id=782800
2017-12-04 17:11:04 +0000 Julien Isorce <[email protected]>
* config/tizonia/gstomx.conf.in:
config: add OMX.Aratelia.audio_decoder.aac to Tizonia config
Useful mostly for testing/debugging purpose as this is a software
based decoder (libfaad) for which GStreamer provides a direct
wrapper.
https://bugzilla.gnome.org/show_bug.cgi?id=791482
2017-11-29 14:18:41 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: retrieve OMX_IndexParamVideoPortFormat before setting it
The usual pattern when setting OMX params is to first get the struct
param, override the values we want to set and then set the updated
param.
We were not doing this with OMX_IndexParamVideoPortFormat and so were
resetting some fields such as OMX_VIDEO_PARAM_PORTFORMATTYPE.xFramerate
https://bugzilla.gnome.org/show_bug.cgi?id=790979
2017-05-21 17:34:51 +0100 Julien Isorce <[email protected]>
* omx/gstomxaacenc.c:
omxaacenc: also set 'profile' if mpegversion is 4
Like done by gst_codec_utils_aac_caps_set_level_and_profile
which is called by avenc_aac, ffaac and voaacenc.
https://bugzilla.gnome.org/show_bug.cgi?id=735208
2017-10-24 12:19:50 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: wait for flush complete and buffers being released when flushing
As stated in the existing comment, when flusing we should wait for OMX
to send the flush command complete event AND all ports being released.
We were stopping as soon as one of those condition was met.
Fix a race between FillThisBufferDone/EmptyBufferDone and the flush
EventCmdComplete messages. The OMX implementation is supposed to release
its buffers before posting the EventCmdComplete event but the ordering
isn't guaranteed as the FillThisBufferDone/EmptyBufferDone and
EventHandler callbacks can be called from different threads (cf 2.7
'Thread Safety' in the spec).
https://bugzilla.gnome.org/show_bug.cgi?id=789475
2017-10-24 11:45:20 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
gst_omx_port_set_flushing: simplify waiting loop
No semantic change so far, I just made the 'while' end condition easier
to understand as a first step before changing it.
- move error/time out checks inside the loop to make it clearer on what
we are actually waiting for.
- group port->buffers checks together with parenthesis as they are part
of the same conceptual check: waiting for all buffers to be released.
https://bugzilla.gnome.org/show_bug.cgi?id=789475
2017-11-27 20:17:17 +1100 Matthew Waters <[email protected]>
* common:
Automatic update of common submodule
From 3f4aa96 to e8c7a71
2017-11-23 15:03:48 +0100 Guillaume Desmottes <[email protected]>
* omx/gstomxh264enc.c:
* omx/gstomxh264utils.c:
zynqultrascaleplus: add support for extra AVC levels
The Zynqultrascaleplus has support for extra AVC levels not defined in
the OMX spec as a customer extension.
https://bugzilla.gnome.org/show_bug.cgi?id=790758
2017-10-16 14:47:07 +0200 Guillaume Desmottes <[email protected]>
* .gitignore:
* Makefile.am:
* config/meson.build:
* configure.ac:
* meson.build:
* tests/Makefile.am:
* tests/check/.gitignore:
* tests/check/Makefile.am:
* tests/check/generic/.gitignore:
* tests/check/generic/states.c:
* tests/check/meson.build:
* tests/meson.build:
add test support
Most of the boilerplate and the states test has been copied from
gst-plugins-good.
https://bugzilla.gnome.org/show_bug.cgi?id=789094
2017-10-17 13:07:05 +0200 Guillaume Desmottes <[email protected]>
* meson.build:
* tools/meson.build:
meson: add tools support
Looks like the tools directory was left out during the initial port to
meson.
https://bugzilla.gnome.org/show_bug.cgi?id=789090
2017-10-16 14:24:50 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: fix build on rpi
The nTimeStamp field is a OMX_TICKS struct on the rpi so use the proper
macro to set it.
Fix build on the build which has been broken by
b3173144b7c1b12c9e1b7571f78659be45d813f6
https://bugzilla.gnome.org/show_bug.cgi?id=789052
2017-10-17 12:11:04 +0200 Guillaume Desmottes <[email protected]>
* configure.ac:
* meson.build:
check if Allegro headers are present when building zynqultrascaleplus
The Zynq UltraScale+ uses a custom version of OMX implementing several
3rd party extensions. Make sure those are present when building this
target.
https://bugzilla.gnome.org/show_bug.cgi?id=788064
2017-10-16 12:42:44 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: remove redundant debug message
We have already a debug message right after.
https://bugzilla.gnome.org/show_bug.cgi?id=789058
2017-10-16 13:26:38 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxh265enc.c:
* omx/gstomxh265utils.c:
omxh265: fix enum casting when using Allegro HEVC extensions
Allegro's HEVC implementation defines a superset of the profiles and
enums from the Android implementation.
Properly cast to fix -Wenum-conversion warnings from clang.
https://bugzilla.gnome.org/show_bug.cgi?id=789057
2017-10-16 13:08:12 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxh265enc.c:
* omx/gstomxvp8dec.c:
properly cast extension enums
OMX's allow 3rds party to define extensions using their own enums
(like OMX_VIDEO_CODINGEXTTYPE) and to be used as the general
ones (like OMX_VIDEO_CODINGTYPE).
Properly cast those to fix -Wenum-conversion warnings from some
compilers such as clang.
https://bugzilla.gnome.org/show_bug.cgi?id=789057
2017-10-09 13:12:35 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: also reset nTimeStamp when re-using buffers
Some OMX implementations may check if the timestamp of the output buffers
they receive is actually not set.
https://bugzilla.gnome.org/show_bug.cgi?id=788711
2017-10-04 17:11:55 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: factor out gst_omx_buffer_reset()
https://bugzilla.gnome.org/show_bug.cgi?id=788711
2017-10-09 17:27:22 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
* omx/gstomx.h:
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
add gst_omx_buffer_flags_to_string()
Make debug logs more readable so users don't have to manually figure out
the meaning of flags.
https://bugzilla.gnome.org/show_bug.cgi?id=788767
2017-09-27 19:47:29 +0530 Ponnam Srinivas <[email protected]>
* omx/gstomxh263enc.c:
h263enc: fix caps leak in error code path
https://bugzilla.gnome.org/show_bug.cgi?id=788245
2017-09-21 15:21:36 +0530 Ponnam Srinivas <[email protected]>
* omx/gstomxh264enc.c:
omxh264enc: fix caps leak
https://bugzilla.gnome.org/show_bug.cgi?id=787711
2017-09-21 11:36:46 +0530 Ponnam Srinivas <[email protected]>
* omx/gstomxh265enc.c:
omxh265enc: fix caps leak
https://bugzilla.gnome.org/show_bug.cgi?id=787714
2017-09-13 15:32:51 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: log info about frame before releasing it
gst_video_decoder_release_frame() takes ownership of the frame and will
destroy it. So we should no longer use it after calling it.
https://bugzilla.gnome.org/show_bug.cgi?id=787628
2017-08-20 20:19:33 +0530 Gurkirpal Singh <[email protected]>
* configure.ac:
configure: Show tizonia target in help
https://bugzilla.gnome.org/show_bug.cgi?id=786544
2017-07-12 14:35:10 +0200 Guillaume Desmottes <[email protected]>
* config/zynqultrascaleplus/gstomx.conf:
* omx/Makefile.am:
* omx/gstomx.c:
* omx/gstomxh265dec.c:
* omx/gstomxh265dec.h:
* omx/meson.build:
omxh265dec: add H265 decoder
Add HEVC decoder for the zynqultrascaleplus platform.
I used the H264 decoder code as a template.
https://bugzilla.gnome.org/show_bug.cgi?id=785434
2017-07-12 11:01:15 +0200 Guillaume Desmottes <[email protected]>
* config/zynqultrascaleplus/gstomx.conf:
* configure.ac:
* meson.build:
* omx/Makefile.am:
* omx/gstomx.c:
* omx/gstomxh265enc.c:
* omx/gstomxh265enc.h:
* omx/gstomxh265utils.c:
* omx/gstomxh265utils.h:
* omx/meson.build:
omxh265enc: add H265 encoder
The OMX spec doesn't support HEVC but the OMX stack of the
zynqultrascaleplus adds it as a custom extension.
It uses the same API as the one of Android's OMX stack.
I used the H264 encoder code as a template.
https://bugzilla.gnome.org/show_bug.cgi?id=785434
2017-08-28 13:56:22 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: use caps from query in propose_allocation
Prevent crash by not deferencing a NULL pointer if self->input_state
isn't defined when propose_allocation() is called.
https://bugzilla.gnome.org/show_bug.cgi?id=786442
2017-09-04 09:34:03 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomx.c:
omx: display states as string if changing failed
Improve the error message by displaying the states in their string
representation rather than their numerical value.
https://bugzilla.gnome.org/show_bug.cgi?id=787235
2017-08-22 10:22:45 +0100 Julien Isorce <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: EGLDisplay is not indirectly defined by gstgl headers inclusion
Just use gpointer as done in GstGL to not include
EGL/egl.h just for EGLDisplay.
https://bugzilla.gnome.org/show_bug.cgi?id=784779
2017-07-14 16:34:04 +0530 Gurkirpal Singh <[email protected]>
* config/tizonia/gstomx.conf.in:
config: expose OMX.mesa h264 decoder and encoder in Tizonia config
https://bugzilla.gnome.org/show_bug.cgi?id=783976
2017-08-11 07:48:37 -0700 Julien Isorce <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: remove wrong SettingsChanged ack
Partially revert 1b7d0b8:
omxvideodec: handle IL 1.2 behavior for OMX_SetParameter
It turned out it was a problem in the decoder which was
not updating some local variables upon SetParameter.
https://bugzilla.gnome.org/show_bug.cgi?id=783976
2017-07-20 09:43:19 +0100 Julien Isorce <[email protected]>
* omx/gstomxaudiodec.c:
* omx/gstomxaudioenc.c:
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
omx{audio,video}{dec,enc}: sequentially disable ports because buffers are not shared
For the history, the parallel disable port has been introduced by:
"00be69f omxvideodec: Disable output port when setting a new format"
and then replicated to videoenc, audiodec and audioenc.
This is only required to do 'parallel' if buffers are shared between ports.
But for decoders and encoders the input and output buffer are of different
nature by definition (bitstream vs images). So they cannot be shared.
Also starting from IL 1.2.0 it is written in the spec that the parallel
disable is not allowed and will return an error. Except when buffers are
shared.
Again here we know in advance that they are not shared so let's always
do a sequential disable.
Tested on Desktop, rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=786348
2017-08-17 12:26:05 +0100 Tim-Philipp Müller <[email protected]>
* common:
Automatic update of common submodule
From 48a5d85 to 3f4aa96
2017-08-10 12:16:53 -0400 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
omxvideodec: use the decoder API to set latency
https://bugzilla.gnome.org/show_bug.cgi?id=785125
2017-07-06 14:19:19 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
omxvideoenc/dec: declare latency on zynqultrascaleplus
The OMX specification doesn't provide any API to expose the latency
introduced by encoders and decoders. We implemented this as a custom
extension as declaring the latency is needed for live pipelines like
video conferencing.
https://bugzilla.gnome.org/show_bug.cgi?id=785125
2017-08-07 13:16:01 -0400 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: adjust stride and slice height from input
Use the stride and slice height information from the first buffer meta
data to adjust the settings of the input port.
This will ensure that the OMX input buffers match the GStreamer ones
and so will save us from having to copy line-by-line each one.
This is also the first step to allow the OMX encoder to receive dmabuf.
Tested on rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
2017-08-07 11:45:29 -0400 Guillaume Desmottes <[email protected]>
* omx/gstomxvideoenc.c:
omxvideoenc: delay buffer configuration until component is enabled
No significant change for now. Just delay the input port configuration
of the buffer size related fields (stride, slice height, buffer size)
until the component is activated.
This will allow us to use the actual stride/height of the first input
and so avoid the buffer copying code path in most cases.
Tested on rpi and zynqultrascaleplus.
https://bugzilla.gnome.org/show_bug.cgi?id=785967
2017-07-24 13:52:35 +0200 Guillaume Desmottes <[email protected]>
* omx/gstomxvideodec.c:
* omx/gstomxvideoenc.c:
omxvideodec/enc: delay allocation after the allocation query
Allocating OMX components buffers in set_format() is too early.
Doing it when receiving the first buffers will allow the element to use
the information from the allocation query and/or the first incoming
buffer to pick to best allocation mode.
Tested on raspberry pi with dynamic resolution changes on decoder and