Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addLogListener should be instance method #83

Open
haashem opened this issue Aug 21, 2024 · 2 comments
Open

addLogListener should be instance method #83

haashem opened this issue Aug 21, 2024 · 2 comments
Milestone

Comments

@haashem
Copy link

haashem commented Aug 21, 2024

Hi,

static method addLogListener is shared between multiple instance of Logger in different packages, which causes the caught exception in main package still being reported because the other package is logging the exception as error.

as you see in my main app I have caught the exception, but the SpotifySDK (third party package) reporting the exception as error and collides with my logger extension! and cause unwanted logging errors!

Is it possible to make it instance method?

Screenshot 2024-08-21 at 20 25 26

Screenshot 2024-08-21 at 20 25 49

Screenshot 2024-08-21 at 20 27 21

@Bungeefan Bungeefan added this to the 3.0.0 milestone Aug 21, 2024
@Bungeefan
Copy link
Member

Hi, yeah, sounds like a good idea.
What do you think about renaming these ones to addGlobalLogListener and naming the new per-instance ones addLogListener? Would make more sense to me.

@Bungeefan
Copy link
Member

I published my prototype for this under the 3.0.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants