Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metric units from the controller #10

Open
SphtKr opened this issue Jan 9, 2025 · 0 comments
Open

Support metric units from the controller #10

SphtKr opened this issue Jan 9, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@SphtKr
Copy link
Owner

SphtKr commented Jan 9, 2025

The aqualogic API has a method to detect this condition, but it's unclear when its result will be valid (and in theory, it could change!) and in any case it will happen after the discovery metadata is published. Likely, the values will probably need to be always published to MQTT in one set of units, and be converted by aqualogic_mqtt if necessary if they don't match what is published, unfortunately.

One less elegant option would be to require the user to specify as an argument whether metric units are expected from the controller, and make it the user's responsibility to make sure it matches reality (else behavior is undefined). This may be the MVP solution, actually.

@SphtKr SphtKr added the enhancement New feature or request label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant