Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system message(s) support #8

Closed
SphtKr opened this issue Jan 9, 2025 · 0 comments · Fixed by #24
Closed

Add system message(s) support #8

SphtKr opened this issue Jan 9, 2025 · 0 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@SphtKr
Copy link
Owner

SphtKr commented Jan 9, 2025

What I would like to do here is somehow support multiple system messages in a better way than the HA integration does (it keeps switching the message back and forth if there are two). Probably this will be "System Message N" where "N" is 1, 2, 3 ... many questions remain here though.

Is there a maximum? Should all be registered initially? Or should additional ones be added to discovery as they occur? Configure via options? And how to manage their ordering? The goal would be to keep them from "flapping" as much as possible, so somehow we will have to "guess" when one has been cleared, and... then what?

E.g., if there is a "Low Salt" in position 1 and a "Check Cell" message in position 2, and the "Low Salt" condition is cleared, then,

  1. When is the "Low Salt" message considered gone? After a certain time without being seen, or when "Check Cell" cycles back N times without seeing "Low Salt"?
  2. Does "Check Cell" become the message in "System Message 1" or remain in "System Message 2" until it is cleared?

Alternatively, should all known system messages just be published as binary_sensor? Is there a known list somewhere?

@SphtKr SphtKr added the enhancement New feature or request label Jan 9, 2025
@SphtKr SphtKr linked a pull request Jan 27, 2025 that will close this issue
@SphtKr SphtKr closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant