Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit (or recover) on serial exceptions #9

Open
SphtKr opened this issue Jan 9, 2025 · 1 comment · Fixed by #25
Open

Exit (or recover) on serial exceptions #9

SphtKr opened this issue Jan 9, 2025 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@SphtKr
Copy link
Owner

SphtKr commented Jan 9, 2025

I have seen one exception occur, "Serial timeout", which was probably caused by a brief power blink to the controller. In this case, the software hung indefinitely, which is not acceptable.

For a containerized process or system service, exiting non-zero is probably an acceptable action, and simplest, so we'll probably start with that. However, it would be nice to try a reconnect once or twice before exiting, I suppose.

This is a little tricky because of the dual forever loops involved--the aqualogic panel and Paho MQTT--but is probably relatively simple to do... the hardest part may be triggering an exception for testing.

@SphtKr SphtKr added the bug Something isn't working label Jan 9, 2025
@SphtKr
Copy link
Owner Author

SphtKr commented Jan 27, 2025

Can reproduce by pulling the serial cable connection, so that's one down.

@SphtKr SphtKr linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant