Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category resources response doesn't match docs, missing data. #2

Open
PhonicUK opened this issue Dec 8, 2016 · 5 comments
Open

Category resources response doesn't match docs, missing data. #2

PhonicUK opened this issue Dec 8, 2016 · 5 comments

Comments

@PhonicUK
Copy link

PhonicUK commented Dec 8, 2016

The page for resources in a category shows that resources should have a 'contributor' field.

https://spiget.org/documentation/#!/categories/get_categories_category_resources

However a request for this doesn't return that field.

https://api.spiget.org/v2/categories/7/resources

@InventivetalentDev
Copy link
Member

I've edited both the API code and Documentation multiple times, so some things might not match up.
The Documentation repo is located at https://github.com/SpiGetOrg/Documentation, feel free to fix up anything that isn't represented in the actual API response :)

For the category response, the contributors field is defined to be returned, but I think it's one of the fields that doesn't exist in every resources, since not all of them add extra contributors.

@PhonicUK
Copy link
Author

PhonicUK commented Dec 8, 2016

Resources are also always missing the icon information, even for ones that have icons.

@InventivetalentDev
Copy link
Member

Not all routes return the full resource information.
Only https://spiget.org/documentation/#!/resources/get_resources_resource is guaranteed to return all information available about the resource.

@CaptainYarb
Copy link

CaptainYarb commented Dec 12, 2016

Is there any chance we could change the resource listing requests to also include the icon like the get_resources_resource request does? This matches the mcSpigot.org resources functionality and seems overall useful. I understand some may not return an icon for lack thereof.

From what I can tell in the code this seems to be a trivial update in the configuration used by the PHP API server.

@InventivetalentDev
Copy link
Member

Feel free to submit a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants