From 3c8e96f6f56b5bf291ff8472e7f3554a9f186b13 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Mon, 13 Jan 2025 15:19:36 +0100 Subject: [PATCH 1/3] Fix sphinx doc build --- readthedocs.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/readthedocs.yml b/readthedocs.yml index 512fcbc709..2bbdded59e 100644 --- a/readthedocs.yml +++ b/readthedocs.yml @@ -1,5 +1,9 @@ version: 2 +sphinx: + # Path to your Sphinx configuration file. + configuration: docs/conf.py + build: os: ubuntu-22.04 tools: From 9614dc79721c54f1822d277d5916e2dce75f3b64 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Mon, 13 Jan 2025 16:27:06 +0100 Subject: [PATCH 2/3] oups --- readthedocs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readthedocs.yml b/readthedocs.yml index 2bbdded59e..c6c44d83a0 100644 --- a/readthedocs.yml +++ b/readthedocs.yml @@ -2,7 +2,7 @@ version: 2 sphinx: # Path to your Sphinx configuration file. - configuration: docs/conf.py + configuration: doc/conf.py build: os: ubuntu-22.04 From 47a04b31015cb73f15325331d972c2726726cea2 Mon Sep 17 00:00:00 2001 From: Divyansh Gupta Date: Mon, 13 Jan 2025 17:38:59 +0100 Subject: [PATCH 3/3] Change to defaultt value use_binary_file=True for KS4 --- src/spikeinterface/sorters/external/kilosort4.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spikeinterface/sorters/external/kilosort4.py b/src/spikeinterface/sorters/external/kilosort4.py index 2a9fb34267..ec15506006 100644 --- a/src/spikeinterface/sorters/external/kilosort4.py +++ b/src/spikeinterface/sorters/external/kilosort4.py @@ -66,7 +66,7 @@ class Kilosort4Sorter(BaseSorter): "do_correction": True, "keep_good_only": False, "skip_kilosort_preprocessing": False, - "use_binary_file": None, + "use_binary_file": True, "delete_recording_dat": True, } @@ -116,7 +116,7 @@ class Kilosort4Sorter(BaseSorter): "keep_good_only": "If True, only the units labeled as 'good' by Kilosort are returned in the output. (spikeinterface parameter)", "use_binary_file": "If True then Kilosort is run using a binary file. In this case, if the input recording is not binary compatible, it is written to a binary file in the output folder. " "If False then Kilosort is run on the recording object directly using the RecordingExtractorAsArray object. If None, then if the recording is binary compatible, the sorter will use the binary file, otherwise the RecordingExtractorAsArray. " - "Default is None. (spikeinterface parameter)", + "Default is True. (spikeinterface parameter)", "delete_recording_dat": "If True, if a temporary binary file is created, it is deleted after the sorting is done. Default is True. (spikeinterface parameter)", }