You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is subject to negotiation as to the order of implementation, and what other things are considered high priority. All v2 endpoints should be in swagger or openapi. other sponge projects using these apis will rely on auto generated clients based on these api definition files.
All endpoints except potentially download should require tokens
All endpoints should be grouped via routes, and in code as if ore's backend was separate microservices to enable us to split out ore into microservices in the future to enable us to scale ore better.
Wanted to write down my thoughts in the API right now:
Consider making sessions optional for public use, they add no purpose for us. People can simply create new sessions on a new IP at any point in time to bypass any form of rate limiting you could impose on a session. I would suggest simply rate-limiting public users by IP address and not session key. If people do wanna use sessions on public use, fine but I don't see an argument for enforcing it.
Currently after receiving your session the HTTP standard Authorization header is being used, there's a few issues with this approach how it is right now:
some libraries add standard handling for this header and may simply not support our obviously non-standard schema
What I would suggest instead is just creating our own header, this will avoid any potential conflicts. I would suggest: OreSession: key
I also read the linked issues for using JWT, but I agree this is currently probably not needed.
This is subject to negotiation as to the order of implementation, and what other things are considered high priority. All v2 endpoints should be in swagger or openapi. other sponge projects using these apis will rely on auto generated clients based on these api definition files.
All endpoints except potentially download should require tokens
Priority endpoints to implement equivalents of in v2 api
The text was updated successfully, but these errors were encountered: