Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themed / Monochrome app icon support #7

Open
sebastien46 opened this issue Dec 17, 2023 · 8 comments
Open

Themed / Monochrome app icon support #7

sebastien46 opened this issue Dec 17, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request medium priority Feature request / bug is medium priority

Comments

@sebastien46
Copy link

Feature Description

From Android 13 onward, the launcher can request an app's themed / monochrome variant.
I'd like to work on this, if you have a source vector file it would be greatly appreciated.
Android Developer Documentation

Screenshots

@sebastien46 sebastien46 added the enhancement New feature or request label Dec 17, 2023
@SrS2225a
Copy link
Owner

Thats a great idea! The source icon can always be found in the fastlane conf. Specifically https://github.com/SrS2225a/custom_uploader/blob/master/fastlane/metadata/android/en-US/images/icon.png

If needed, I have also supplied light and dark icons, which have been attached below. I wish you luck, and thanks for taking time time to improve my project :)

app logo PNG-resized app logo BLACK app logo PNG app logo WHITE

@sebastien46
Copy link
Author

sebastien46 commented Dec 18, 2023

Thats a great idea! The source icon can always be found in the fastlane conf. Specifically https://github.com/SrS2225a/custom_uploader/blob/master/fastlane/metadata/android/en-US/images/icon.png

If needed, I have also supplied light and dark icons, which have been attached below. I wish you luck, and thanks for taking time time to improve my project :)
app logo PNG-resized app logo BLACK app logo PNG app logo WHITE

I'm sorry to disappoint you @SrS2225a, but it seems I underestimated the difference between regular Android development & Flutter development 😞
I think someone with more Flutter experience can probably easily pull this off, I'll leave a monochrome vector here once I've made it.
BTW, are you sure you don't have an SVG file of this image?

@SrS2225a
Copy link
Owner

SrS2225a commented Dec 18, 2023

That's alright if you cant do it. Flutter is a bit different from normal android development, but still similar so I will provide you with further assistance. I think the issue you are running into is that you cant find where the main root of "android" is; as icons, manifest, etc is handled the exact same way as you would do it with standard android development, so you just need to add adaptive icons as any other app. Android can be found by following the directory path: custom_uploader/android/app/src/main/.

I only went with flutter in the first place because I was planning on having it for ios as well, and wanted an easy way to develop for the two, but because of Apple's walled garden, that never happened. Also, unfortunately I do not have an svg of the app icon, but you could properly put it in a online converter such as https://convertio.co/png-svg/ which you can find plenty of, if not I can ask the original artist to provide me one.

@sebastien46
Copy link
Author

sebastien46 commented Dec 18, 2023

I think the issue you are running into is that you cant find where the main root of "android" is; as icons, manifest, etc is handled the exact same way as you would do it with standard android development, so you just need to add adaptive icons as any other app. Android can be found by following the directory path: custom_uploader/android/app/src/main/.

The main issue I'm having is going in blind because Drawable previews don't work with the Android Studio Flutter Plugin (probably some gradle sync shenanigans)

you could properly put it in a online converter

That wouldn't work, as it would only put the raster in an svg, not create SVG path data, which is what I'm currently doing by tracing the raster shape in Inkscape.
But, since the bitmaps you provided don't have clean edges, the edge tracer in Inkscape has a really hard time making it work, so I have to mainly do it by hand.

I can ask the original artist to provide me one.

Could you do that? I would really appreciate it.

@SrS2225a
Copy link
Owner

The main issue I'm having is going in blind because Drawable previews don't work with the Android Studio Flutter Plugin (probably some gradle sync shenanigans)

Thank you. Yeah, it is because of gradle. It think it's because flutter compiles with dart instead of java. The way I get around this issue is that I open the android subdirectory as its own separate project in Android Studio. See https://docs.flutter.dev/tools/android-studio#android-ide

@SrS2225a
Copy link
Owner

Hello, just wanted to see how that icon is coming along since it has been pretty quiet here for a while. Unfortunately, I was not able to get back in touch with the artist. I do have their email from when requested the work, so I could try that way, but I wish to respect their privacy.

@clach04
Copy link

clach04 commented Feb 18, 2024

you could properly put it in a online converter

That wouldn't work, as it would only put the raster in an svg, not create SVG path data, which is what I'm currently doing by tracing the raster shape in Inkscape. But, since the bitmaps you provided don't have clean edges, the edge tracer in Inkscape has a really hard time making it work, so I have to mainly do it by hand.

I can recommend https://potrace.sourceforge.net/ its definitely easier than by hand and then you can either clean it up or trace that.

@SrS2225a SrS2225a added the medium priority Feature request / bug is medium priority label Feb 29, 2024
@SrS2225a
Copy link
Owner

Greetings, I was not able to get in touch with the original artist of the logo as they seemed to have left the platform I scored the commission from, even after giving him way more than generous time to send a replay. So eventually, I decided to say F it, ill just commission another logo, that in fact has svgs this time, especially since it was holding up further development. I was never really fully happy with the original logo anyways; but the new one looks so much better.

Anyways, the new logos can be found on my media server in a .rar archive: https://media.fenriris.net/talI2/ZufIzALO49.rar @sebastien46. I will also try to do this myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority Feature request / bug is medium priority
Projects
None yet
Development

No branches or pull requests

3 participants