Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressStaticGZip #102

Open
Gobleizer opened this issue Apr 26, 2022 · 0 comments
Open

ExpressStaticGZip #102

Gobleizer opened this issue Apr 26, 2022 · 0 comments

Comments

@Gobleizer
Copy link

app.use('/', expressStaticGzip(path.join(__dirname, '..', 'client', 'dist'), {

It's cool that you are using ExpressStaticGZip, but I think it's not immediately obvious why. Also compared to your other routes, it appears messy.
Use the same separation of concerns you did with the other routes, to clean this up. Utilize ExpressStaticGZip in controller code that would be named/wrapped in a way that makes it obvious what you are accomplishing with that route. And remove the outdated comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant