-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.3.0 #211
Open
Maximilian-Stefan-Ernst
wants to merge
130
commits into
main
Choose a base branch
from
release/v0.3.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/v0.3.0 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace comm_matrix helper functions with a CommutationMatrix and overloaded linalg ops
Cleanup Special Matrices code
* identifier() -> param_indices() (Dict{Symbol, Int}) * get_identifier_indices() -> param_to_indices() (Vector{Int}) * parameters -> params (Vector{Symbol})
convert() is a proper method to call to avoid unnecessary construction, ctor semantics requires that a new object is constructed
make the type immutable
* use graph as a main parameter * simplify rows processing * don't reallocate table.columns Co-authored-by: Maximilian-Stefan-Ernst <[email protected]>
because the ParTable contains rows and columns, it is not clear, what sort() actually sorts. Co-authored-by: Maximilian-Stefan-Ernst <[email protected]>
* use named tuples * reduce code duplication * use colnames vector instead of position_names Dict
* declare RAMConstant field types * refactor constants collection to avoid code duplication
for clarity
* explicitly use Cholesky factorization
remove unnecesary arguments
by dispatching over optimizer
by dispatching over optimizer
no wrapper required
to reduce allocations
to reduce allocations
to avoid extra allocation
Co-authored-by: Maximilian Ernst <[email protected]>
Refactor objective/gradient/hessian evaluation
Add data simulation function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.