Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command timeout/reconnection strategy #81

Open
jesperstarkar opened this issue Jul 19, 2017 · 2 comments
Open

Command timeout/reconnection strategy #81

jesperstarkar opened this issue Jul 19, 2017 · 2 comments
Assignees
Labels

Comments

@jesperstarkar
Copy link
Member

Since there's no ping-protocol in AMCP, only sent messages can probe the socket's state. This can not be done at a lower level, due to node.js net.Socket restrictions.

So, when a command times out, we can expect the Socket to be down, IF the command was sent properly (which we normally can expect).

At the moment, we discard sent commands that time out. This should be one of three options:

  1. Discard
  2. Retry (max attempts)
  3. Verify and choose (test a simple INFO-command, then choose to discard or retry)
@jesperstarkar jesperstarkar self-assigned this Jul 19, 2017
@jesperstarkar jesperstarkar changed the title Command timeout/reconnection strategu Command timeout/reconnection strategy Jul 19, 2017
jesperstarkar added a commit that referenced this issue Jul 19, 2017
Started planning of better command timeout/retry strategies.

Related to #81
@sparkpunkd
Copy link
Contributor

PING command added in 2.1.x onwards ... but still an issue for 2.0.7.

@jesperstarkar
Copy link
Member Author

Discard has issues - we end up sending multiple commands again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants