Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was Whitening implemented incorrectly? #14

Open
jsrdcht opened this issue Apr 19, 2023 · 1 comment
Open

Was Whitening implemented incorrectly? #14

jsrdcht opened this issue Apr 19, 2023 · 1 comment

Comments

@jsrdcht
Copy link

jsrdcht commented Apr 19, 2023

whitening operation, which is implemented by a non-parametric layer normalization operator without scaling and bias

You mentioned that the whitening operation is non-parametric. But it seems you implemented it by norm operation from the original paper which is not non-parametric.

if self.feat_after_norm:
      if 'CLIP' in self.pred_feat:
          x_tgt = self.feature_model.visual.ln_post(x_tgt)
@yaoyuan10475
Copy link

I found that the author's teacher model output has gone through a norm(self.feature_model.norm(x_tgt)), and then there is self.ln_tgt(x_tgt). The output equivalent to the teacher model has gone through Layer Norm twice. I don't quite understand this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants