Sample preview volume not linked to the volume of the clip and row the sample will be loaded into #1591
Labels
ui-undesireable
Not a bug but should be changed
Milestone
Please describe the problem:
Sample preview happens outside of the clip render here: https://github.com/SynthstromAudible/DelugeFirmware/blob/ce76f1bb14f5e66c0322088577027fc5a160b682/src/deluge/processing/engines/audio_engine.cpp#L783
As a result it can have dramatically different volumes during preview than after it is selected
What is the expected behavior?
Same sound during preview as after loading - so probably the param manager for preview needs to copy the one for the active row with volume multiplied by the kit and song volumes
Is there a relevant Pull request?
No response
What hardware did you reproduce it with?
OLED
What firmware did you reproduce it with?
Nightly
What is the firmware name:
No response
If possible provide the steps to reproduce the issue and upload additional media:
No response
The text was updated successfully, but these errors were encountered: