Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample preview volume not linked to the volume of the clip and row the sample will be loaded into #1591

Open
m-m-adams opened this issue Mar 25, 2024 · 0 comments
Labels
ui-undesireable Not a bug but should be changed

Comments

@m-m-adams
Copy link
Collaborator

Please describe the problem:

Sample preview happens outside of the clip render here: https://github.com/SynthstromAudible/DelugeFirmware/blob/ce76f1bb14f5e66c0322088577027fc5a160b682/src/deluge/processing/engines/audio_engine.cpp#L783

As a result it can have dramatically different volumes during preview than after it is selected

What is the expected behavior?

Same sound during preview as after loading - so probably the param manager for preview needs to copy the one for the active row with volume multiplied by the kit and song volumes

Is there a relevant Pull request?

No response

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Nightly

What is the firmware name:

No response

If possible provide the steps to reproduce the issue and upload additional media:

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-undesireable Not a bug but should be changed
Projects
None yet
Development

No branches or pull requests

1 participant