Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiating resampling fast in arranger view misses the first playback of a sample (and doesn't resample it) #2262

Open
sichtbeton opened this issue Jul 7, 2024 · 3 comments
Labels
bug Something isn't working official bug is present on official firmware

Comments

@sichtbeton
Copy link
Contributor

Please describe the problem:

When trying to resample this song and pushing the combo "record" + "play" fast, it doesnt play the main sample for the first time. it does catch up and play it the second bar around. contrary when doing the combo slower, it works as expected.

here is a video for it:

test.klein.mov

the song in question:

https://drive.google.com/file/d/14xGaZgkDKFA7WlozfBc3il-QEXsaMz-p/view?usp=sharing

What is the expected behavior?

play sample from beginning and resample correctly

Is there a relevant Pull request?

no

What hardware did you reproduce it with?

OLED

What firmware did you reproduce it with?

Built from community

What is the firmware name:

1.2.9-DEV-5C8AF7B

If possible provide the steps to reproduce the issue and upload additional media:

  • load song
  • go to arranger
  • press record and play fast
@sichtbeton sichtbeton changed the title fast initiating resampling in arranger view misses the first playback of a sample (and doesn't resample it) initiating resampling fast in arranger view misses the first playback of a sample (and doesn't resample it) Jul 7, 2024
@m-m-adams m-m-adams added the bug Something isn't working label Jul 8, 2024
@m-m-adams
Copy link
Collaborator

It's being culled - appears to be a pre existing bug from official, there's a word of Rohan comment about attempts to fix it in AudioRecorder::beginOutputRecording()

@sapphire-arches sapphire-arches added the official bug is present on official firmware label Jul 8, 2024
@sapphire-arches sapphire-arches added this to the Release 1.2 milestone Jul 8, 2024
@sichtbeton
Copy link
Contributor Author

Oh, right so it’s a rather deep issue I presume?

@m-m-adams
Copy link
Collaborator

Just needs investigation. The function rohan commented in isn't the one causing the issue so someone needs to figure out which one actually is

@m-m-adams m-m-adams modified the milestones: Release 1.2, Future release Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working official bug is present on official firmware
Projects
None yet
Development

No branches or pull requests

3 participants