Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note should allow model.divBottomPart (and possibly more) #2606

Open
joeytakeda opened this issue Oct 15, 2024 · 0 comments
Open

note should allow model.divBottomPart (and possibly more) #2606

joeytakeda opened this issue Oct 15, 2024 · 0 comments

Comments

@joeytakeda
Copy link
Contributor

At the moment, <note>s can contain paragraphs and other "component-level elements", but cannot contain openers or closers; however, there are cases where footnotes are certainly signed. For example, from The Lyon in Mourning:

Screenshot 2024-10-15 at 2 33 34 PM

Here, you can see a footnote denoting editorial intervention by Robert Forbes who (to prove authenticity) signs the note. It's important for the project that we capture which notes had been signed (and by whom), but this encoding is invalid:

<note>
    <p>Here ended Belfinlay's Hand-writing &amp;
    <lb/>what follows I took from the Mouth of 
    <lb/>Capn Donald Roy MacDonald.</p>
    <closer>
        <signed>Robert Forbes, A:M</signed>
    </closer>
</note>

At present, the content model of <note> is macro.specialPara, which "defines the content model of elements such as notes or list items, which either contain a series of component-level elements or else have the same structure as a paragraph, containing a series of phrase-level and inter-level elements." That content model is:

<content>
 <alternate minOccurs="0"
  maxOccurs="unbounded">
  <textNode/>
  <classRef key="model.gLike"/>
  <classRef key="model.phrase"/>
  <classRef key="model.inter"/>
  <classRef key="model.divPart"/>
  <classRef key="model.global"/>
 </alternate>
</content>

It's used by a whole host of elements, though, so I'm not sure whether it makes more sense to special-case <note> (and add model.divBottomPart to its content model) or if it ought to be part of macro.specialPara (which is used by things like <quote> and <item> which I could imagine containing closers and signed, but I don't have any examples at hand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants