Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher Types #23

Open
drewroberts opened this issue Feb 13, 2021 · 5 comments
Open

Voucher Types #23

drewroberts opened this issue Feb 13, 2021 · 5 comments
Assignees

Comments

@drewroberts
Copy link
Member

We'll begin to use voucher types for restrictions on how vouchers can be applied during the checkout process.

@pdbreen
Copy link
Contributor

pdbreen commented Feb 17, 2021

Discounts are always pre-tax adjustments (tax is calculated on the discounted total). Are vouchers always treated like cash (or a gift card) where the voucher amount is applied to the after tax total? Or will there be a mix? Some vouchers will be treated as cash and reduce the overall payment due, tax included - but others will be more like a discount that reduces the amount prior to tax calculation? Iff the initial thinking is a voucher can be either - can we eliminate the mix by creating single use discounts instead leaving discounts always pre-tax and vouchers always post-tax?

@drewroberts
Copy link
Member Author

Can we eliminate the mix by creating single-use discounts instead, leaving Discounts always pre-tax and Vouchers always post-tax?

Yes, this would make things simpler. Vouchers will always be post-tax.

@drewroberts
Copy link
Member Author

Should Voucher Types be switched to just an ENUM on the voucher model as we've been doing with types on other models?

The main things for types on the Voucher model was for various conditional application logic that may be needed like we do with Discounts.

Vouchers should also be able to be used for a number of participants or a specific product, etc. instead of a dollar amount. I had initially planned to use Types for that approach.

@pdbreen
Copy link
Contributor

pdbreen commented Mar 10, 2021

No. A VoucherType is a sellable, so it needs a distinct model backing it.

@drewroberts
Copy link
Member Author

That's right. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants