Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spark shows that the mod is laggy with the yeetUpdateSuppressionCrash_implOnTickWorlds method #136

Closed
2 tasks done
MrPacha23 opened this issue Jan 27, 2024 · 3 comments
Closed
2 tasks done
Labels
duplicate This issue or pull request already exists

Comments

@MrPacha23
Copy link

Bug description

Hello, I have been having problems on my server with the TPS and the MSPT, it is very laggy on some occasions, I have consulted the technicians at the server host and they have made me run a spark test and they have found the problem that This is being the mod. I am attaching the link of the problem that spark is launching so that you can verify it and see what solution can be given. I ran 3 tests, I attach all of them.

First test: https://spark.lucko.me/djKU5R6nZw
Second test: https://spark.lucko.me/1v3PAGdEQD
Third test: https://spark.lucko.me/iOmrZqp32C

Steps to reproduce

Every so often

Expected behavior

Let it go correctly

Actual behavior

It's laggy

Relevant logs

First test: https://spark.lucko.me/djKU5R6nZw
Second test: https://spark.lucko.me/1v3PAGdEQD
Third test: https://spark.lucko.me/iOmrZqp32C

Minecraft version

1.20.4

Carpet TIS Addition version

1.55.0

Fabric Carpet version

1.4.128

Other information

No response

Check list

  • I have verified that the issue persists in the latest version of the mod.
  • I have searched the existing issues and confirmed that this is not a duplicate.
@Fallen-Breath
Copy link
Contributor

duplicate of #118. unrelated to this mod

@Fallen-Breath
Copy link
Contributor

Fallen-Breath commented Jan 27, 2024

In case it's hard for you to read #118 which is in Chinese, here's the explaination in English:

yeetUpdateSuppressionCrash_implOnTickWorlds is a wrapper function of the ServerWorld#tick method, and the latter one is what the world ticking logic of Minecraft is in, which of course takes a lot of times and seems to be "laggy"

You can verify this by:

  1. Inspect the profile tree
    image

  2. Check the flame graph feature
    image

@Fallen-Breath Fallen-Breath closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
@Fallen-Breath Fallen-Breath added the duplicate This issue or pull request already exists label Jan 27, 2024
@MrPacha23
Copy link
Author

MrPacha23 commented Jan 27, 2024

Thank you so much

@Fallen-Breath Fallen-Breath changed the title TPS & MSPT spark profiler shows that yeetUpdateSuppressionCrash_implOnTickWorlds lags the server Mar 6, 2024
@Fallen-Breath Fallen-Breath pinned this issue Mar 6, 2024
@Fallen-Breath Fallen-Breath changed the title spark profiler shows that yeetUpdateSuppressionCrash_implOnTickWorlds lags the server spark shows yeetUpdateSuppressionCrash_implOnTickWorlds is laggy Mar 6, 2024
@Fallen-Breath Fallen-Breath changed the title spark shows yeetUpdateSuppressionCrash_implOnTickWorlds is laggy spark shows that the mod is laggy with the yeetUpdateSuppressionCrash_implOnTickWorlds method Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants