Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_tom should not default to a python version not supported by TOM Toolkit. #5

Open
jchate6 opened this issue Mar 8, 2024 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@jchate6
Copy link
Contributor

jchate6 commented Mar 8, 2024

Currently this defaults to the most recent python version (python 3.12) which is unsupported by TomToolkit

@jchate6 jchate6 added the bug Something isn't working label Mar 8, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Mar 8, 2024

when asked the question about what python to use, I get the following:

Checking for your installed Python...
Found Python 3.12.2 at /usr/bin/python
Do you want to use the Python 3.12.2 at /usr/bin/python? 
Type 'yes' or the pathname of an alternative python executable: (yes/</path/to/python>)? [yes]

It would be nice if I could request a different python VERSION rather than a different python PATH.

@phycodurus
Copy link
Contributor

make-tom.sh is using the shell command command to get information on the installed version of Python. It's not defaulting to any specific version.

If the script asked for a Python VERSION rather than a PATH, it would have to assume the burden of finding the executable of the that Python, and I'd rather the user (who has the knowledge) assume that burden.

@github-project-automation github-project-automation bot moved this from Triage to Closed in TOM Toolkit Mar 11, 2024
@phycodurus phycodurus added the wontfix This will not be worked on label Mar 11, 2024
@jchate6 jchate6 reopened this Mar 11, 2024
@github-project-automation github-project-automation bot moved this from Closed to Triage in TOM Toolkit Mar 11, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Mar 12, 2024

My issue is the default behavior that the script has when the local version of python is not compatible with TOM Toolkit.
Instead of just installing from command -v python we could install from command -v python3.10 or some other compatible python version if the default was unsupported by tom_base.

Basically we could try python versions until we find a compatible one. If they don't have one in their path, the install would fail anyway.

@jchate6 jchate6 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Mar 15, 2024
@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
Status: Backlog
Development

No branches or pull requests

2 participants