Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Poetry 2.0 #92

Closed
jchate6 opened this issue Jan 9, 2025 · 2 comments · Fixed by #93
Closed

Update for Poetry 2.0 #92

jchate6 opened this issue Jan 9, 2025 · 2 comments · Fixed by #93
Labels
dependencies Pull requests that update a dependency file

Comments

@jchate6
Copy link
Contributor

jchate6 commented Jan 9, 2025

The pyproject.toml likely needs to be updated to to be compatible with poetry 2.0.
@github-project-automation github-project-automation bot moved this to Triage in TOM Toolkit Jan 9, 2025
@JulienPeloton
Copy link
Collaborator

Thanks @jchate6 for the heads up -- do you know when you plan to switch to poetry 2.0?

@JulienPeloton JulienPeloton added the dependencies Pull requests that update a dependency file label Jan 10, 2025
@jchate6
Copy link
Contributor Author

jchate6 commented Jan 10, 2025

Thanks @jchate6 for the heads up -- do you know when you plan to switch to poetry 2.0?

Hi @JulienPeloton We have already updated tom_base and plan to gradually move other repos over time.

The main concern is that Poetry updated on January 5th so all of our github workflows that rely on poetry, but don't call a specific version, will now be incompatible with the format of our pyproject.toml.

@jchate6 jchate6 moved this from Triage to Staged in TOM Toolkit Jan 10, 2025
@JulienPeloton JulienPeloton mentioned this issue Jan 31, 2025
Merged
@github-project-automation github-project-automation bot moved this from Staged to Closed in TOM Toolkit Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
TOM Toolkit
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify pyproject for poetry 2.0 TOMToolkit/tom_fink
2 participants
@JulienPeloton @jchate6