Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coremod Issues #7

Open
TYKUHN2 opened this issue Jun 18, 2022 · 0 comments
Open

Fix Coremod Issues #7

TYKUHN2 opened this issue Jun 18, 2022 · 0 comments
Assignees
Labels
bug Something isn't working in-progress Assigned and being worked on
Milestone

Comments

@TYKUHN2
Copy link
Owner

TYKUHN2 commented Jun 18, 2022

Introduction

Some coremods, specifically CodeChickenLib, struggle to load under ForgeGradle 3 due to the lack of GradleStart. We need to identify and correct reasons that launching may differ between the versions, as well as correct other deobfuscation and reflection issues caused by overly aggressive coremods.

Example

CodeChickenLib contains a great example of how this issue occurs. It has been proven under a dev environment, but I have not investigated a production environment. It is unlikely to differ greatly due to how the coremod works.

Proposal

Reimplement GradleStart within some launch class prior to coremod loading. This is not necessarily preferable, but may be required for some mods.

@TYKUHN2 TYKUHN2 added bug Something isn't working in-progress Assigned and being worked on labels Jun 18, 2022
@TYKUHN2 TYKUHN2 added this to the First Release milestone Jun 18, 2022
@TYKUHN2 TYKUHN2 self-assigned this Jun 18, 2022
@TYKUHN2 TYKUHN2 moved this from Todo to In Progress in Minecraft Forge Extended Support Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in-progress Assigned and being worked on
Projects
Development

No branches or pull requests

1 participant