Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate songs #18

Open
yumihoshio opened this issue Oct 2, 2024 · 5 comments
Open

Duplicate songs #18

yumihoshio opened this issue Oct 2, 2024 · 5 comments

Comments

@yumihoshio
Copy link
Contributor

As of right now, when you first run through setup, it won't check for duplicate songs, meaning you can have stacks of the same songs (ex. Ano Bando by Kessoku band)

You can remove duplicate songs by running it through a dictionary during the initial setup, checking for artist and song name.
This will also be nice for the new changes to the UI, seeing how it no longer care about the mappers, and only for song

There was a raise regarding BGs. I think there could be a few options to resolve this

  1. You can simply ignore it and just use whatever BGs get pick through natural selection
  2. During setup, when running through duplicate songs, allow user to pick which one they'd like to keep
    a. This can have 2 options, regular setup and advanced setup.
  3. Let it pick through natural selection, but allow user to change BG

Example of duplicate songs:
{E071C96A-81B8-4DEE-A12D-8E8B999A4F93}
As for TV ver, I think we can either keep it, and allow a toggle for "TV Ver" or keep it, since it is technically a different version, albeit shorter

@CaptSiro
Copy link
Collaborator

CaptSiro commented Oct 2, 2024

Great suggestion. I would lean towards merging the first three songs into one: kessoku band - Ano Band and the other two keeping as separate songs. Afterwards, there could be an icon inside the image indicating that more backgrounds are available. There could be an issue with case-sensitive "merging". In this example third song would be separate because kessoku is with capital K

@yumihoshio
Copy link
Contributor Author

I like the icon idea. Perhaps make it a toggle inside settings so that the icon can still look nice, and only when the user care about changing the BG they can toggle it on and go through it

As for the case-sensitive issue, I think that can be ignored since most, if not all (bold guesses) artists don't have the same name, since getting recognize when you have the same name but different capitalization is.. hard, to say the least. That is just my bold assumptions though
If it's really an issue, I think we could add an extra option to song that can be like "This song is a duplicate" which open up a simple search UI that let you place it into the duplicated song and it'd just be this > there could be an icon inside the image indicating that more backgrounds are available.

Hopefully this explanation make sense 🙏

@NoelleTGS
Copy link

Most mapsets of the same songs use the exact same mp3 file, so that could probably be detected which would make it so we don't have to go just based on title, which would also fix case sensitive issues. This would also prevent songs from getting grouped together where one is the full version and one is a shorter version.

@yumihoshio
Copy link
Contributor Author

Take this with a grain of salt (Maybe several), but I think that would be a lot slower, especially when most osu players have a few thousands of songs. I think it'll be a lot less efficient than simply just going through the title and author.

Unless I'm wrong, and checking the audio file would be faster

@SrIzan10
Copy link
Contributor

calculating hte hash of all mp3s might work, but keep in mind that maybe compression algorithms, timestamps inside metadata files and a large etc can change the result, so i think we should not do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants